Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-4476, OCPBUGS-11702: keepalived/ingress: change healthcheck script #3441

Merged
merged 1 commit into from Apr 26, 2023
Merged

OCPBUGS-4476, OCPBUGS-11702: keepalived/ingress: change healthcheck script #3441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/common/on-prem/files/keepalived-script-default-ingress.yaml
View file
Open in desktop
Expand Up @@ -3,4 +3,4 @@ path: "/etc/kubernetes/static-pod-resources/keepalived/scripts/chk_default_ingre
contents:
inline: |
#!/bin/bash
/host/bin/oc --kubeconfig /var/lib/kubelet/kubeconfig get ep -n openshift-ingress router-internal-default -o yaml | grep -q 'ip: {{`{{.NonVirtualIP}}`}}$'
/host/bin/crictl -r unix:///host/run/crio/crio.sock pods --namespace openshift-ingress --state Ready | grep -q 'router-default-[[:xdigit:]]\{10\}-[[:alnum:]]\{5\}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have recently seen some bugs around older bootimages during scale-up. Since we are going to switch to use crirctl, can you please confirm if this crictl functionality was present in crictl shipped in OCP 4.1 bootimage?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add to the comment above (because it's not trivial to find this out), OCP 4.1 bootimage corresponds to the RHCOS 410.8.20190520.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-04-26-151604_930x150_scrot

Seems to me like crictl back in OCP 4.1 bootimage contains what we need here, i.e. pods command

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming!