pkg/daemon: check channel closing #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
runcom
force-pushed
the
fix-ssh-accessed
branch
2 times, most recently
from
5e5156a
to
9ca6f9d
Compare
openshift-ci-robot
added
size/M
runcom
force-pushed
the
fix-ssh-accessed
branch
from
9ca6f9d
to
4053ed5
Compare
openshift-ci-robot
added
size/XS
|
/test unit |
runcom
force-pushed
the
fix-ssh-accessed
branch
from
4053ed5
to
2d3dac0
Compare
runcom
changed the title
|
/test e2e-aws |
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
/approve |
openshift-ci-robot
added
lgtm
ashcrow
approved these changes
Feb 4, 2019
|
/lgtm |
jlebon
reviewed
Feb 4, 2019
On reboot, the SessionNew subscribed channel gets closed causing the node ssh/accessed annotation to be added. This patch fixes that by checking if the channel is indeed closing before going ahead and add the annotation. Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
fix-ssh-accessed
branch
from
2d3dac0
to
6e9f76d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, jlebon, runcom, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #372, after this patch, no ssh/accessed annotation is applied on a machine config addition.
On reboot, the SessionNew subscribed channel gets closed
causing the node ssh/accessed annotation to be added.
This patch fixes that by checking if the channel is indeed
closing before going ahead and add the annotation.
Haven't added an e2e cause watching for something not to happen is gonna be the best flake ever, I'll defer to add proper testing around ssh/accessed being added on real login in a follow up.
Signed-off-by: Antonio Murdaca runcom@linux.com