pkg/daemon: run login monitor for Degraded nodes #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
/approve |
openshift-ci-robot
added
the
approved
|
/hold until pre-req is merged |
openshift-ci-robot
added
the
do-not-merge/hold
yuqi-zhang
approved these changes
Feb 4, 2019
If there would ever be a way to reconcile a Degraded node, I believe it would be worth to still learn if someone jumped on a node and messed up with it so we can decide what to do. Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
run-login-monitor-early
branch
from
c79a817
to
eea9777
Compare
|
rebased and push forced |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
ashcrow
approved these changes
Feb 4, 2019
|
pre-req merged, code looks fine to me. Deferring to a second review for merge. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, runcom, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there would ever be a way to reconcile a Degraded node, I believe it
would be worth to still learn if someone jumped on a node and messed up
with it so we can decide what to do.
Feel free to close this telling I'm dumb as well, I'm probably missing some context which led to this PR while playing around reading the code but it makes sense to me to still have something like this. This is also not fixing anything related to super early startup where someone can jump on a node before the daemon is running and tracking accesses.
This PR builds on #373, I'll rebase it once that merges