MCO-681, OCPBUGS-20427: Add Key State Metrics, No datapoint found when querying up certain registered metrics #3965
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@inesqyx: This pull request references MCO-681 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-merge-robot
added
needs-rebase
inesqyx
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@inesqyx: This pull request references Jira Issue OCPBUGS-20427, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@inesqyx: This pull request references Jira Issue OCPBUGS-20427, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
inesqyx
force-pushed
the
MCO-681
branch
2 times, most recently
from
bb308fa
to
3b1a64c
Compare
|
/retest-required |
|
/test verify |
|
/retest-required |
|
/test ci/prow/okd-scos-images |
|
@inesqyx: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test okd-scos-images |
1 similar comment
|
/test okd-scos-images |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test unit |
1 similar comment
|
/test unit |
|
There is a problem with the way we clean the
We will track this behaviour here: |
inesqyx
force-pushed
the
MCO-681
branch
2 times, most recently
from
1ae8079
to
5230cbd
Compare
|
/hold For qe-approval |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inesqyx, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-aws-ovn-upgrade |
|
Given the date of the feature freeze, we have decided to approve this PR now and fix the problem regarding the mcd_config_drift metric later using another PR later. The behaviour regarding the mcd_config_drift metric will be tracked here: https://issues.redhat.com/browse/OCPBUGS-24003 /label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
Sounds good, thanks Sergio! |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test e2e-hypershift |
|
@inesqyx: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@inesqyx: Jira Issue OCPBUGS-20427: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20427 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-proxy-pull-test-container-v4.15.0-202311292108.p0.g16b16ef.assembly.stream for distgit openshift-proxy-pull-test. |
TRT-1375: Revert #3965 "MCO-681, OCPBUGS-20427: Add Key State Metrics, No datapoint found when querying up certain registered metrics"
In this PR, I have enabled several metrics to report key state of the MCC & MCD
MCCSubControllerState, which has label"subcontroller, state object, to record the action of the subcontroller on certain object e.g.machine-config-controller-render Sync Machine Config Pool master timestampA--> the render controller has synced the master pool at timestamp A.I have also fixed the bug reported in https://issues.redhat.com/browse/OCPBUGS-20427:
Before: when query for
mcc_drain_err, it returnsno datapoint foundNow: when query for
mcc_drain_err, it returns the initial value set until change happened