Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1375: Revert #3965 "MCO-681, OCPBUGS-20427: Add Key State Metrics, No datapoint found when querying up certain registered metrics" #4051

Merged

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Nov 30, 2023

Reverts #3965 ; tracked by TRT-1375

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

10/10 GCP upgrades failed on MCDPivotError firing on the last payload, https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/aggregated-gcp-ovn-rt-upgrade-4.15-minor-release-openshift-release-analysis-aggregator/1730187997023834112

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test payload blocking jobs, /payload 4.15 nightly blocking

CC: @inesqyx

PR created by Revertomatic™️

This reverts commit 16b16ef, reversing
changes made to 637f757.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 30, 2023

@stbenjam: This pull request references TRT-1375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #3965 ; tracked by TRT-1375

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

10/10 GCP upgrades failed on MCDPivotError firing on the last payload, https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/aggregated-gcp-ovn-rt-upgrade-4.15-minor-release-openshift-release-analysis-aggregator/1730187997023834112

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test payload blocking jobs, /payload 4.15 nightly blocking

CC: @inesqyx

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 30, 2023

@stbenjam: This pull request references TRT-1375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #3965 ; tracked by TRT-1375

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

10/10 GCP upgrades failed on MCDPivotError firing on the last payload, https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/aggregated-gcp-ovn-rt-upgrade-4.15-minor-release-openshift-release-analysis-aggregator/1730187997023834112

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test payload blocking jobs, /payload 4.15 nightly blocking

CC: @inesqyx

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 30, 2023

/label approved
/skip

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@stbenjam
Copy link
Member Author

/override ci/prow/e2e-aws-ovn
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-gcp-op-layering
/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-aws-ovn-upgrade
/skip

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op, ci/prow/e2e-gcp-op-layering, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift, ci/prow/okd-scos-e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-gcp-op-layering
/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-aws-ovn-upgrade
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

/override ci/prow/e2e-aws-ovn
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-gcp-op-layering
/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-aws-ovn-upgrade
/skip

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op, ci/prow/e2e-gcp-op-layering, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift, ci/prow/okd-scos-e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-gcp-op-layering
/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-aws-ovn-upgrade
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

/test unit

@openshift-merge-bot openshift-merge-bot bot merged commit 6cfe686 into openshift:master Nov 30, 2023
14 checks passed
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.15.0-202312010209.p0.g6cfe686.assembly.stream for distgit ose-machine-config-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants