Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple consts in pkg/daemon #397

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Decouple consts in pkg/daemon #397

merged 1 commit into from
Feb 8, 2019

Conversation

runcom
Copy link
Member

@runcom runcom commented Feb 8, 2019 •
edited

Just refactor, no change in behavior nor nothing (but do please check!)

TL;DR; consts are the only thing shared and by having their own package we can enable cgo just in daemon (as well as having better code in general, I pretend)

Closes #396 and you can build daemon only with cgo

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@jlebon
Copy link
Member

jlebon commented Feb 8, 2019

I'm confused how the osrelease package split helps; it's only used in the daemon already, right? Or is this just for re-organizing and not actually necessary for #396?

@runcom
Copy link
Member Author

runcom commented Feb 8, 2019

I'm confused how the osrelease package split helps; it's only used in the daemon already, right? Or is this just for re-organizing and not actually necessary for #396?

it's not used just in daemon package, it's also used in cmd/*-daemon package (those are 2 different package)

@runcom
Copy link
Member Author

runcom commented Feb 8, 2019

oh well, it doesn't help right, it's just better to have it there that way

jlebon
jlebon reviewed Feb 8, 2019
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise looks sane to me! I like the idea of keeping shared consts in a separate pkg to make it easier to tell how things are connected.

cmd/machine-config-daemon/start.go Outdated Show resolved Hide resolved
@runcom
pkg/daemon: create a constants package
7e80ebd 
to be used across the whole project. Also, unexport some of the consts
that were previously wrongly exported.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@jlebon
Copy link
Member

jlebon commented Feb 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom
Copy link
Member Author

runcom commented Feb 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 5964541 into openshift:master Feb 8, 2019
@runcom runcom deleted the decouple-consts branch February 8, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon left review comments

@ashcrow ashcrow Awaiting requested review from ashcrow

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@jlebon jlebon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@runcom @jlebon @openshift-ci-robot @openshift-merge-robot