NO-ISSUE: add e2e-techpreview-shared, remove layering test target

[djoshy]

- What I did
This PR adds a new test package, e2e-techpreview-shared. This test package should be used for e2e tests that need to be tested under the default featureset and the techpreview featureset. This would mean that your test
has two paths, one when the feature gate is enabled and one when the feature gate is disabled. Tests added here will run under the test-e2e and test-e2e-techpreview Makefile targets, which is used by ci/prow/e2e-gcp-op and ci/prow/e2e-gcp-op-techpreview test suites respectively.

This PR also removes the old makefile target for e2e-gcp-op-layering which has now been repurposed into e2e-gcp-op-techpreview.

This should merge after openshift/release#48618 merges.

- How to verify it

• tests, including the new e2e-gcp-op-techpreview should succeed
• both e2e-gcp-op and e2e-gcp-op-techpreview should run TestNoop.

[openshift-ci-robot]

@djoshy: This pull request explicitly references no jira issue.

In response to this:

- What I did
This removes the old makefile target for e2e-gcp-op-layering which has now been repurposed into e2e-gcp-op-techpreview. This should merge after openshift/release#48618 merges.

- How to verify it
e2e-gcp-op-techpreview should succeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[cheesesashimi]

Let's use this PR to lay the foundation for sharing tests between the test/e2e and test/e2e-techpreview packages. I don't think that we need to use something as complicated as the e2e-shared pattern that I originally envisioned. Instead, we can rely on the fact that go test will let you specify multiple test targets on the CLI. We'll add another test package under test/ and modify the Makefile targets to run that as well. For this example, we'll call this new test package e2e-featuregated, which isn't the best name so feel free to change it if you think of something better.

Here's how we can add it:

1. $ mkdir -p test/e2e-featuregated
2. Add a file at test/e2e-featuregated/noop_test.go containing something like the following:

package e2e_featuregated_test

import "testing"

func TestNoop(t *testing.T) {
	t.Logf("In TestNoop")
}

3. Adjust the test-e2e and test-e2e-techpreview Makefile targets thusly:

test-e2e: install-go-junit-report
     set -o pipefail; go test -tags=$(GOTAGS) -failfast -timeout 150m -v$${WHAT:+ -run="$$WHAT"} ./test/e2e/ ./test/e2e-featuregated/ | ./hack/test-with-junit.sh $(@)

test-e2e-techpreview: install-go-junit-report
     set -o pipefail; go test -tags=$(GOTAGS) -failfast -timeout 150m -v$${WHAT:+ -run="$$WHAT"} ./test/e2e-techpreview/ ./test/e2e-featuregated/ | ./hack/test-with-junit.sh $(@)

When you push this up, look for TestNoop to show up in test output to verify that it is actually running. Now, any tests added to ./test/e2e-featuregated will execute in both the test-e2e and test-techpreview test suites 😄

We may also want to put a README.md in the test/e2e-featuregated package as well to explain that.

[djoshy]

/test e2e-gcp-op

[djoshy]

Taking this out of draft as openshift/release#48618 merged. I've gone with Zack's idea and added a short Readme as well (:

[cheesesashimi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi,djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	24fd263	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202402140927.p0.g53a9e00.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.