Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change e2e-gcp-op-layering to e2e-gcp-op-techpreview #48618

Conversation

cheesesashimi
Copy link
Member

@cheesesashimi cheesesashimi commented Feb 8, 2024

As we place more features behind FeatureGates, there will be a need to ensure that these features are actually activated and have e2e test coverage. This job is being renamed to indicate that it can be used to test features that are behind FeatureGates.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@cheesesashimi
Copy link
Member Author

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-techpreview

@cheesesashimi cheesesashimi force-pushed the zzlotnik/e2e-gcp-op-layering-rename branch from e45d63a to 10a3f12 Compare February 8, 2024 21:26
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@cheesesashimi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-techpreview openshift/machine-config-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@djoshy
Copy link

djoshy commented Feb 13, 2024

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-techpreview

@openshift-ci-robot
Copy link
Contributor

@djoshy, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't get ref: Get "http://ghproxy/repos/openshift/release/git/refs/heads/master": dial tcp 172.30.229.2:80: i/o timeout

@djoshy
Copy link

djoshy commented Feb 13, 2024

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-techpreview

1 similar comment
@cheesesashimi
Copy link
Member Author

/pj-rehearse pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-techpreview

@djoshy
Copy link

djoshy commented Feb 13, 2024

/retest-required

1 similar comment
@cheesesashimi
Copy link
Member Author

/retest-required

@djoshy
Copy link

djoshy commented Feb 13, 2024

/pj-rehearse ack

/lgtm

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 13, 2024
@djoshy
Copy link

djoshy commented Feb 13, 2024

/lgtm

Hello bot

@djoshy
Copy link

djoshy commented Feb 13, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link

djoshy commented Feb 13, 2024

/remove-label do-not-merge/work-in-progress

1 similar comment
@cheesesashimi
Copy link
Member Author

/remove-label do-not-merge/work-in-progress

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@djoshy: The label(s) /remove-label do-not-merge/work-in-progress cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label do-not-merge/work-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@cheesesashimi: The label(s) /remove-label do-not-merge/work-in-progress cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label do-not-merge/work-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheesesashimi cheesesashimi marked this pull request as draft February 13, 2024 17:54
@cheesesashimi cheesesashimi marked this pull request as ready for review February 13, 2024 17:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@cheesesashimi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1070aea into openshift:master Feb 13, 2024
19 checks passed
mshitrit pushed a commit to mshitrit/release that referenced this pull request Feb 14, 2024
shaior pushed a commit to natifridman/release that referenced this pull request Feb 14, 2024
sgoveas pushed a commit to sgoveas/release that referenced this pull request Feb 22, 2024
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants