OCPBUGS-29732: Always touch resolv-prepender file at end of script

[cybertron]

PR #4196 made this conditional based on whether changes were actually made to resolv.conf. Unfortunately, because resolv.conf is persistent over reboots this means that we never touch it after the initial deployment and as a result on subsequent boots kubelet will never start because the file is never created.

Because we don't care whether changes were actually made, only that resolv.conf is correctly generated, we can move this file creation out of the if block and always do it to fix the problem.

Note that this probably does not happen with OVNKubernetes because the creation of br-ex triggers DNS changes (it gets cleared and then re-populated) so this is only relevant for OpenShiftSDN-based envs.

- What I did

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@cybertron: This pull request references Jira Issue OCPBUGS-29732, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

PR #4196 made this conditional based on whether changes were actually made to resolv.conf. Unfortunately, because resolv.conf is persistent over reboots this means that we never touch it after the initial deployment and as a result on subsequent boots kubelet will never start because the file is never created.

Because we don't care whether changes were actually made, only that resolv.conf is correctly generated, we can move this file creation out of the if block and always do it to fix the problem.

Note that this probably does not happen with OVNKubernetes because the creation of br-ex triggers DNS changes (it gets cleared and then re-populated) so this is only relevant for OpenShiftSDN-based envs.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cybertron]

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/jira refresh

[openshift-ci-robot]

@cybertron: This pull request references Jira Issue OCPBUGS-29732, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cybertron]

/cc @mkowalski

[stbenjam]

/lgtm

[openshift-ci]

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	f9534f3	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change	f9534f3	link	false	/test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sinnykumari]

e2e-metal-ipi test is green
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, sinnykumari, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mkowalski]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

@cybertron: Jira Issue OCPBUGS-29732: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#4207

Jira Issue OCPBUGS-29732 has been moved to the MODIFIED state.

In response to this:

PR #4196 made this conditional based on whether changes were actually made to resolv.conf. Unfortunately, because resolv.conf is persistent over reboots this means that we never touch it after the initial deployment and as a result on subsequent boots kubelet will never start because the file is never created.

Because we don't care whether changes were actually made, only that resolv.conf is correctly generated, we can move this file creation out of the if block and always do it to fix the problem.

Note that this probably does not happen with OVNKubernetes because the creation of br-ex triggers DNS changes (it gets cleared and then re-populated) so this is only relevant for OpenShiftSDN-based envs.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202402211110.p0.g39334cf.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-02-22-021321