Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29732: Always touch resolv-prepender file at end of script #4207

Merged

Commits on Feb 20, 2024

  1. OCPBUGS-29732: Always touch resolv-prepender file at end of script

    PR openshift#4196 made this conditional based on whether changes were
    actually made to resolv.conf. Unfortunately, because resolv.conf is
    persistent over reboots this means that we never touch it after the
    initial deployment and as a result on subsequent boots kubelet will
    never start because the file is never created.
    
    Because we don't care whether changes were actually made, only that
    resolv.conf is correctly generated, we can move this file creation
    out of the if block and always do it to fix the problem.
    
    Note that this probably does not happen with OVNKubernetes because
    the creation of br-ex triggers DNS changes (it gets cleared and then
    re-populated) so this is only relevant for OpenShiftSDN-based envs.
    cybertron committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f9534f3 View commit details
    Browse the repository at this point in the history