Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2465: Updates GCR CredentialProviderConfig #4260

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Mar 13, 2024

- What I did

This change updates the GCR CredentialProviderConfig to pass the 'get-credentials' argument, which is required for the credential plugin to function correctly.

It also adds a matcher for "*.pkg.dev"

- How to verify it

  • Enable the DisableKubeletCloudCredentialProviders feature flag
  • Create a deployment that pulls from a private GCR image
  • Verify the image does not fail to pull

- Description for the changelog

Updates GCR CredentialProviderConfig, passing 'get-credentials' and updating matchers

@theobarberbany theobarberbany changed the title Updates GCR CredentialProviderConfig OCPCLOUD-2465: Updates GCR CredentialProviderConfig Mar 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2024

@theobarberbany: This pull request references OCPCLOUD-2465 which is a valid jira issue.

In response to this:

- What I did

This change updates the GCR CredentialProviderConfig to pass the 'get-credentials' argument.

It also adds a matcher for "*.pkg.dev"

- How to verify it

  • Enable the DisableKubeletCloudCredentialProviders feature flag
  • Create a deployment that pulls from a private GCR image
  • Verify the image does not fail to pull

- Description for the changelog

Updates GCR CredentialProviderConfig, passing 'get-credentials' and updating matchers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2024
matchImages:
- "gcr.io"
- "*.gcr.io"
- "*.pkg.dev"
Copy link
Contributor

@JoelSpeed JoelSpeed Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is the Google artifact registry, which is a new version of GCR

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
This change updates the GCR CredentialProviderConfig to pass the
'get-credentials' argument.

It also adds a matcher for "*.pkg.dev"
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@theobarberbany
Copy link
Contributor Author

^ Just a rebase to see if CI is fixed

@JoelSpeed
Copy link
Contributor

Looks to be build cluster issues
/retest

@JoelSpeed
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

CI looking a lot healthier now
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2024

@theobarberbany: This pull request references OCPCLOUD-2465 which is a valid jira issue.

In response to this:

- What I did

This change updates the GCR CredentialProviderConfig to pass the 'get-credentials' argument, which is required for the credential plugin to function correctly.

It also adds a matcher for "*.pkg.dev"

- How to verify it

  • Enable the DisableKubeletCloudCredentialProviders feature flag
  • Create a deployment that pulls from a private GCR image
  • Verify the image does not fail to pull

- Description for the changelog

Updates GCR CredentialProviderConfig, passing 'get-credentials' and updating matchers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, theobarberbany, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@theobarberbany
Copy link
Contributor Author

/check-required-labels

@theobarberbany
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d9ffefd into openshift:master Mar 18, 2024
15 of 17 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

@theobarberbany: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 55cee2c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403181742.p0.gd9ffefd.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants