Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-2573: Enables kubelet cloud credential providers #1786

Merged
merged 1 commit into from Mar 28, 2024
Merged

OCPCLOUD-2573: Enables kubelet cloud credential providers #1786

merged 1 commit into from Mar 28, 2024

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Mar 7, 2024 •
edited

Enables the DisableKubeletCloudCredentialProviders feature gate

Cloud credential providers for AWS, GCP and Azure are now functional. We can disable the in tree kubelet providers.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

Hello @theobarberbany! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 7, 2024
@theobarberbany theobarberbany marked this pull request as ready for review March 8, 2024 15:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2024
@JoelSpeed
Copy link
Contributor

/test e2e-gcp

@JoelSpeed
Copy link
Contributor

Need an e2e-gcp to prove this is working as expected
/test e2e-gcp

@theobarberbany
Copy link
Contributor Author

theobarberbany commented Mar 11, 2024 •
edited

GCP e2es are a bit sad at the moment, but it's being worked on :)

I don't think the failures are related to this PR!

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2024
@theobarberbany theobarberbany force-pushed the enable-credential-providers branch 2 times, most recently from da5de8f to 75b5ca3 Compare March 13, 2024 10:15
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2024
@JoelSpeed
Copy link
Contributor

Changes LGTM but I need to see a pass on GCP before we can merge this

@theobarberbany
Copy link
Contributor Author

GCP is failing due to a configuration error.

openshift/machine-config-operator#4260 fixes that.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@JoelSpeed
Copy link
Contributor

/test e2e-gcp

Cluster failed to bootstrap

@JoelSpeed
Copy link
Contributor

Private registry tests appear to be passing, among other inconsistent and spurious failures
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6e22bae and 2 for PR HEAD 2d24f30 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2252c7a and 1 for PR HEAD 2d24f30 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 85cbc2e and 0 for PR HEAD 2d24f30 in total

@openshift-ci-robot
Copy link

/hold

Revision 2d24f30 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024
@theobarberbany
Enables DisableKubeletCloudCredentialProviders feature gate
fd10d8f 
Enables the DisableKubeletCloudCredentialProviders feature gate

Cloud credential providers for AWS, GCP and Azure are now functional. We
can disable the in tree kubelet providers.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2024
@theobarberbany
Copy link
Contributor Author

/test e2e-azure

@theobarberbany
Copy link
Contributor Author

/test e2e-aws-serial

damdo
damdo reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member

damdo commented Mar 27, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef1813b and 2 for PR HEAD fd10d8f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cd3ad5c and 1 for PR HEAD fd10d8f in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f8aa75d into openshift:master Mar 28, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403280418.p0.gf8aa75d.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@damdo damdo

@JoelSpeed JoelSpeed

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@theobarberbany @JoelSpeed @openshift-ci-robot @sunzhaohua2 @damdo @openshift-bot @openshift-merge-robot