-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.16] OCPBUGS-35364: Azure: add Azure specific dnsmasq ordering #4406
[release-4.16] OCPBUGS-35364: Azure: add Azure specific dnsmasq ordering #4406
Conversation
In 4.14 we slightly tweaked the services such that mcd-pull no longer depends on network-online.target. This broke some ARO disconnected environments that needed dnsmasq to be ready before the MCD-pull runs on firstboot. Add in a new Azure template for MCD-pull with an additional After=dnsmasq.service so the strict ordering of: 1. ovs-configuration 2. dnsmasq 3. mcd-pull 4. mcd-firstboot is adhered to.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-35300 has been cloned as Jira Issue OCPBUGS-35364. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35364, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/jira refresh |
@yuqi-zhang: This pull request references Jira Issue OCPBUGS-35364, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label backport-risk-assessed
/cherry-pick release-4.15
This should be a completely safe template as it only adds dependency on dnsmasq, which is a no-op if it doesn't exist
/test e2e-azure |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/label cherry-pick-approved |
6cde409
into
openshift:release-4.16
@openshift-cherrypick-robot: Jira Issue OCPBUGS-35364: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-35364 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.15 release-4.14 |
@sinnykumari: new pull request created: #4408 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.16.0-202406140906.p0.g6cde409.assembly.stream.el9 for distgit ose-machine-config-operator. |
Fix included in accepted release 4.16.0-0.nightly-2024-06-18-054744 |
This is an automated cherry-pick of #4404
/assign yuqi-zhang