OCPBUGS-39226: Enable the use of Linux Bridge as the ovs default port connection #4545
Conversation
The linux bridge can be configured to add a virtual switch between one or many ports. This can be done by a simple machine config that adds: "bridge=br0:enpf0,enpf2 ip=br0:dhcp" to the the kernel command line options which will be processed by dracut. The use case of adding such a virtual bridge for simple IEEE802.1 switching is to support PCIe devices that act as co-processors in a baremetal server. For example: -------- --------------------- | Host | PCIe | Co-processor | | eth0|<------->|enpf0 <-br0-> enpf2|<---> network | | | | -------- --------------------- This co-processor could be a "DPU" network interface card. Thus the co-processor can be part of the same underlay network as the cluster and pods can be scheduled on the Host and the Co-processor. This allows for pods to be offloaded to the co-processor for scaling. Signed-off-by: William Zhao <wizhao@redhat.com>
|
/cc @jcaamano |
|
/retest |
|
/lgtm |
|
/retest |
|
/lgtm |
|
/retest |
|
@yuqi-zhang How do I get the acknowledge-critical-fixes-only, approved labels? The acknowledge-critical-fixes-only label looks strange for pushing a change to master. |
|
/retitle NO-JIRA: Enable the use of Linux Bridge as the ovs default port connection |
openshift-ci
bot
changed the title
|
@wizhaoredhat: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@wizhaoredhat the label can be applied by almost anyone I think (or maybe just repo owners), see the email titled I can certainly apply this label but since this is a no-jira PR, that normally indicates a trivial change or doc update that doesn't affect much and is not urgent to merge. Is this a feature or a bugfix instead? If so we should probably link a Jira to properly context. |
|
@yuqi-zhang good point. I think this a feature that can be tested. Would this be an OCP BUG. I can create this. |
|
Based on your description I think either could work. I suggest opening an OCPBUGS card if you want to backport this to previous versions (current master would be 4.18) or a feature card if you do not plan to backport. |
|
/retitle OCPBUGS-39226: Enable the use of Linux Bridge as the ovs default port connection |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@wizhaoredhat: This pull request references Jira Issue OCPBUGS-39226, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@wizhaoredhat: This pull request references Jira Issue OCPBUGS-39226, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@yuqi-zhang Good point! I think we might want this in 4.17. I created the OCPBUG targeting 4.18. Please take a look to see if this can be merged now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222, jcaamano, wizhaoredhat, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/test |
|
@wizhaoredhat: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
1 similar comment
|
/retest |
1 similar comment
|
@wizhaoredhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit a3d9b1f
into
openshift:master
|
@wizhaoredhat: Jira Issue OCPBUGS-39226: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-39226 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
|
/cherry-pick release-4.16 |
|
@wizhaoredhat: new pull request created: #4563 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.17 |
|
@wizhaoredhat: new pull request created: #4567 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The linux bridge can be configured to add a virtual switch between one or many ports. This can be done by a simple machine config that adds:
"bridge=br0:enpf0,enpf2 ip=br0:dhcp"
to the the kernel command line options which will be processed by dracut.
The use case of adding such a virtual bridge for simple IEEE802.1 switching is to support PCIe devices that act as co-processors in a baremetal server. For example:
This co-processor could be a "DPU" network interface card. Thus the co-processor can be part of the same underlay network as the cluster and pods can be scheduled on the Host and the Co-processor. This allows for pods to be offloaded to the co-processor for scaling workloads.