daemon: Explicitly stop kubelet.service first before rebooting #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is resurrecting the other part of: openshift#237 Basically it's not advantageous to us to try to shut down everything at once; we want to ensure kubelet can fully shut itself down gracefully, and only after that initiate the reboot for the rest of the machine. This also sets the MCD up to be in full explicit control of kubelet shutdown; e.g. if we wanted to configure timeout behavior more, we could easily do that with this "2 phase" shutdown (though it would involve some custom code and not a shell script one-liner).
openshift-ci-robot
added
size/XS
|
The thing we want to add at some point on top of this that #237 was trying to do is ensure that kubelet's |
|
lgtm |
|
@rphillips Were you intentionally omtting a |
ashcrow
approved these changes
May 22, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is resurrecting the other part of:
#237
Basically it's not advantageous to us to try to shut down everything
at once; we want to ensure kubelet can fully shut itself down
gracefully, and only after that initiate the reboot for the rest
of the machine.
This also sets the MCD up to be in full explicit control of
kubelet shutdown; e.g. if we wanted to configure timeout behavior
more, we could easily do that with this "2 phase" shutdown (though
it would involve some custom code and not a shell script one-liner).