Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] manifests: Show machine counts in oc get machineconfigpools output #985

Merged
merged 1 commit into from
Sep 25, 2019
Merged

[4.3] manifests: Show machine counts in oc get machineconfigpools output #985

merged 1 commit into from
Sep 25, 2019

Conversation

LorbusChris
Copy link
Member

@LorbusChris LorbusChris commented Jul 18, 2019 •
edited
Loading

by adding new printer columns

Closes: #903

- What I did
Add columns to the MachineConfigPool CRD manifest
to show machine counts for each pool in output of oc get mcp

- How to verify it
oc get mcp shows MACHINECOUNT columns containing the number of machines in each pool

- Description for the changelog
Add machine counts info on oc get mcp output

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 18, 2019
@LorbusChris LorbusChris changed the title Show machine counts in oc get machineconfigpools output manifests: Show machine counts in oc get machineconfigpools output Jul 18, 2019
@runcom
Copy link
Member

runcom commented Jul 18, 2019

/approve

pretty sure you're using the wrong version of go-bindata though

/assign ericavonb

@LorbusChris LorbusChris force-pushed the showmachinecounts branch 2 times, most recently from 99eb853 to 1b0d135 Compare July 18, 2019 14:29
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2019
@LorbusChris
Copy link
Member Author

/retest

2 similar comments
@LorbusChris
Copy link
Member Author

/retest

@runcom
Copy link
Member

runcom commented Jul 19, 2019

/retest

ericavonb
ericavonb reviewed Jul 24, 2019
View reviewed changes
manifests/machineconfigpool.crd.yaml
@@ -22,6 +22,10 @@ spec:
description: When progress is blocked on updating one or more nodes, or the pool configuration is failing.
name: Degraded
type: string
- JSONPath: .status.machineCount
description: Total number of machines in the machine config pool
name: MachineCount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we show "degraded", "ready", and "updated" counts as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also UnavailableMachineCount, no need for it to show here?

@LorbusChris
manifests: Add machine counts info on oc get mcp output
2aa7ac9 
Add columns to the MachineConfigPool CRD manifest
to show machine counts for each pool.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2019
@LorbusChris LorbusChris added the 4.3 label Aug 2, 2019
@LorbusChris LorbusChris changed the base branch from master to master-4.3 August 2, 2019 14:40
@LorbusChris LorbusChris changed the title manifests: Show machine counts in oc get machineconfigpools output [4.3] manifests: Show machine counts in oc get machineconfigpools output Aug 2, 2019
@LorbusChris LorbusChris changed the base branch from master-4.3 to master August 8, 2019 22:08
@runcom
Copy link
Member

runcom commented Sep 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom
Copy link
Member

runcom commented Sep 24, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 2aa7ac9 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d4ec1af into openshift:master Sep 25, 2019
@LorbusChris LorbusChris deleted the showmachinecounts branch September 26, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericavonb ericavonb ericavonb left review comments

@ashcrow ashcrow Awaiting requested review from ashcrow

@runcom runcom Awaiting requested review from runcom

Assignees

@runcom runcom

@ericavonb ericavonb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show machine counts in oc get machineconfigpools output
6 participants
@LorbusChris @runcom @openshift-ci-robot @openshift-bot @ericavonb @openshift-merge-robot