New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update control-plane-operator policy #1469
Update control-plane-operator policy #1469
Conversation
/assign @jharrington22 |
cfafd9a
to
c82a9d9
Compare
@csrwng Is this specific to hypershift? |
@fahlmant yes it is. The entire control plane operator policy is only used in hypershift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is HS specific, should go in https://github.com/openshift/managed-cluster-config/blob/master/resources/sts/4.12/hypershift/ControlPlaneOperatorPolicy.json ?
The control-plane-opertor needs additional permissions in order to create and destroy a default security group for NodePools where no security group is specified.
c82a9d9
to
23b879d
Compare
Thanks @jharrington22. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, jharrington22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@csrwng: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
feature
What this PR does / why we need it?
The control-plane-opertor needs additional permissions in order to create and destroy a default security group for NodePools where no security group is specified.
Which Jira/Github issue(s) this PR fixes?
Fixes # HOSTEDCP-789
Special notes for your reviewer:
Pre-checks (if applicable):
Tested latest changes against a cluster
Included documentation changes with PR
If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with: