Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-21742] - Added admin gates for 4.16 #2127

Merged
merged 1 commit into from
May 28, 2024

Conversation

xiaoyu74
Copy link
Contributor

@xiaoyu74 xiaoyu74 commented May 22, 2024

What type of PR is this?

(feature)

What this PR does / why we need it?

Added admin gates for 4.16

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/OSD-21742

For reviewers:

OCM gate and admin-acks are created based on the new feature gate reported by QE: feature gate

  • OCM Gate added for 4.16
ocm get /api/clusters_mgmt/v1/version_gates | jq -r '.items[] | select(.version_raw_id_prefix=="4.16")'
{
  "kind": "VersionGate",
  "id": "abc08218-17ef-11ef-9b4e-0a580a820515",
  "href": "/api/clusters_mgmt/v1/version_gates/abc08218-17ef-11ef-9b4e-0a580a820515",
  "version_raw_id_prefix": "4.16",
  "label": "api.openshift.com/gate-ocp",
  "value": "4.16",
  "warning_message": "To prevent an outage on your cluster, review any APIs in use that will be removed, and migrate them to the appropriate new API version. Failure to evaluate and migrate components affected by this update can cause some types of workloads to stop functioning.",
  "description": "OpenShift removes several Kubernetes APIs, including flowschemas (flowcontrol.apiserver.k8s.io/v1beta2) and prioritylevelconfigurations (flowcontrol.apiserver.k8s.io/v1beta2) in OpenShift 4.16.",
  "documentation_url": "https://access.redhat.com/articles/6955985",
  "sts_only": false,
  "creation_timestamp": "2024-05-22T03:59:21.791747Z"
}

@xiaoyu74 xiaoyu74 changed the title Added admin gates for 4.16 [OSD-21742] - Added admin gates for 4.16 May 22, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@bmeng
Copy link
Contributor

bmeng commented May 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 28, 2024

@xiaoyu74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f4c24f2 into openshift:master May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants