Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DNSErrors05MinSRE alert #400

Closed
wants to merge 1 commit into from
Closed

Remove DNSErrors05MinSRE alert #400

wants to merge 1 commit into from

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 21, 2020

Signed-off-by: Ben Ye yb532204897@gmail.com

https://issues.redhat.com/browse/OSD-4437

We are porting this alert to upstream cluster-dns-operator, so we can remove this alert here.

Please hold this pr until openshift/cluster-dns-operator#184 gets merged.

@yeya24 yeya24 requested a review from RiRa12621 July 21, 2020 14:59
RiRa12621
RiRa12621 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@RiRa12621 RiRa12621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
waiting for #400 to land in the product

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@lisa
Copy link
Contributor

lisa commented Jul 21, 2020

Should the associated exporter be removed as well?

@RiRa12621
Copy link
Contributor

Yes but I would have pinged you about that, once this is through as I don't know if we want to keep maintaining it or rather archive it.

@yeya24
Copy link
Contributor Author

yeya24 commented Jul 22, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@yeya24
Copy link
Contributor Author

yeya24 commented Jul 22, 2020

Upstream pr is merged, this should be good to go!

@RiRa12621
Copy link
Contributor

/hold
Waiting for upstream to actually land on OSD

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 28, 2020
@RiRa12621
Copy link
Contributor

/remove-lifecycle rotten
/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Nov 30, 2020
@yeya24
remove DNSErrors05MinSRE alert
7d243db 
Signed-off-by: Ben Ye <yb532204897@gmail.com>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RiRa12621, yeya24
To complete the pull request process, please assign nautilux after the PR has been reviewed.
You can assign the PR to them by writing /assign @nautilux in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker cblecker closed this Sep 15, 2021
@lisa
Copy link
Contributor

lisa commented Sep 15, 2021

@cblecker Why was this closed? Can we retire https://github.com/openshift/managed-prometheus-exporter-dns ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiRa12621 RiRa12621 RiRa12621 approved these changes

@lisa lisa Awaiting requested review from lisa

@mbarnes mbarnes Awaiting requested review from mbarnes

Assignees

@RiRa12621 RiRa12621

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yeya24 @lisa @RiRa12621 @openshift-bot @openshift-ci-robot @cblecker