Script SRE can use to manage upgrades of clusters.

[jewzaam]

See README for how to use.
Note you have to run the script multiple times, so it's a less than ideal. But it's a start..

[mwoodson]

/lgtm

[lisa]

Have some idiomatic Bash suggestions.

[cblecker]

I started reviewing this, and left some specific comments.. but there are two things throughout the script that should be fixed up:

• Anywhere a variable is used in a command passed to bash, it should be double quoted to prevent shell globbing
• Anywhere a variable is called (and especially if it's concatenated with another string) it should be wrapped in curly brackets.

The other thing I see is if you're creating temporary files on the filesystem they should either be created out of tree (in $TMPDIR or something), or they should be gitignored so they don't get committed to the git tree.

[jewzaam]

@cblecker @lisa @mwoodson could I get another look post-changes? thanks

[lisa]

Some changes requested and some comments/questions.

Main overall theme is that $OCP_VERSION_FROM will always be set so checking for it to be set after lines 6-13 is redundant.

[jewzaam]

@lisa note if using -n $var need to use [[ -n $var ]]

[lisa]

@lisa note if using -n $var need to use [[ -n $var ]]

Is [ -z $var ] ok though?

[jewzaam]

@lisa note if using -n $var need to use [[ -n $var ]]

Is [ -z $var ] ok though?

No, that might as well be [ true ] though I didn't dig into the why.. just needed a solution to make it work. [ ! -z $var ] works too.

[jewzaam]

@lisa note if using -n $var need to use [[ -n $var ]]

Is [ -z $var ] ok though?

No, that might as well be [ true ] though I didn't dig into the why.. just needed a solution to make it work. [ ! -z $var ] works too.

Missed this is asking -z, not -n... I haven't checked. Given there's a working solution I'm in favor of stopping. Not really keen on learning all the nuances of these options in bash tbh.

[lisa]

/lgtm
/approve