[release-4.12] OCPBUGS-15771: Fix metallb controller condition reason string

[liornoy]

This commit brings a fix to the metallb controller that is missing from 4.12, 4.11.

The fix:
The Reason string in Condition object can't be empty and must have atleast one character. so use condition string when it's empty.

[openshift-ci-robot]

@liornoy: This pull request references Jira Issue OCPBUGS-15771, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.z) matches configured target version for branch (4.12.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-8433 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-8433 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
• bug has dependents

Requesting review from QA contact:
/cc @asood-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit brings a fix to the metallb controller that is missing from 4.12, 4.11.

The fix:
The Reason string in Condition object can't be empty and must have atleast one character. so use condition string when it's empty.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgoncalves]

For reference, the upstream PR is metallb#219
Any reason why you are not also backporting the test code?
metallb@56b095d#diff-84511590037f485163cb9de0451ef94fdd46c1955b3464b2b84ab050bf007b89

[liornoy]

For reference, the upstream PR is metallb#219 Any reason why you are not also backporting the test code? metallb@56b095d#diff-84511590037f485163cb9de0451ef94fdd46c1955b3464b2b84ab050bf007b89

because they are added here: c4cd3bf

[cgoncalves]

/lgtm

[fedepaol]

/override ci/prow/ci-index-upgrade-bundle

[fedepaol]

/approve
/lgtm

[fedepaol]

/label backport-risk-assessed

[openshift-ci]

@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/ci-index-upgrade-bundle

In response to this:

/override ci/prow/ci-index-upgrade-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@liornoy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, liornoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fedepaol]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[asood-rh]

/label cherry-pick-approved

[openshift-ci-robot]

@liornoy: Jira Issue OCPBUGS-15771: All pull requests linked via external trackers have merged:

• openshift/metallb-operator#174
• openshift/metallb-operator#176

Jira Issue OCPBUGS-15771 has been moved to the MODIFIED state.

In response to this:

This commit brings a fix to the metallb controller that is missing from 4.12, 4.11.

The fix:
The Reason string in Condition object can't be empty and must have atleast one character. so use condition string when it's empty.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liornoy]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@liornoy: new pull request created: #177

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.