Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-15966: Fix metallb controller condition reason string #177

Merged
merged 1 commit into from Jul 10, 2023
Merged

[release-4.11] OCPBUGS-15966: Fix metallb controller condition reason string #177

merged 1 commit into from Jul 10, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #176

/assign liornoy

@liornoy
Fix metallb controller condition reason string
7c7662a 
This commit brings a fix to the metallb controller
that is missing from 4.12, 4.11.

The fix:
The Reason string in Condition object can't be empty and must have atleast
one character. so use condition string when it's empty.

Signed-off-by: liornoy <lnoy@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 9, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15771 has been cloned as Jira Issue OCPBUGS-15966. Will retitle bug to link to clone.
/retitle [release-4.11] OCPBUGS-15966: Fix metallb controller condition reason string

In response to this:

This is an automated cherry-pick of #176

/assign liornoy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] OCPBUGS-15771: Fix metallb controller condition reason string [release-4.11] OCPBUGS-15966: Fix metallb controller condition reason string Jul 9, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 9, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15966, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-15771 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-15771 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @asood-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #176

/assign liornoy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liornoy
Copy link

liornoy commented Jul 9, 2023

/retest

@fedepaol
Copy link
Member

/approve
/lgtm

@fedepaol
Copy link
Member

/override ci/prow/ci-index-upgrade-bundle

@fedepaol
Copy link
Member

/override ci/prow/operator-e2e-upgrade

@fedepaol
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 10, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/ci-index-upgrade-bundle

In response to this:

/override ci/prow/ci-index-upgrade-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

@fedepaol: Overrode contexts on behalf of fedepaol: ci/prow/operator-e2e-upgrade

In response to this:

/override ci/prow/operator-e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5c08d09 into openshift:release-4.11 Jul 10, 2023
8 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15966: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15966 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #176

/assign liornoy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asood-rh asood-rh Awaiting requested review from asood-rh

@dougbtv dougbtv Awaiting requested review from dougbtv

@msherif1234 msherif1234 Awaiting requested review from msherif1234

Assignees

@fedepaol fedepaol

@liornoy liornoy

@asood-rh asood-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @liornoy @fedepaol @asood-rh @openshift-merge-robot