-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.13] OCPBUGS-33759: FRR: squash advertisements with the same prefix #174
[release-4.13] OCPBUGS-33759: FRR: squash advertisements with the same prefix #174
Conversation
Passing multiple advertisements with the same prefix to the template causes duplicate entries. This happens for example when the shared ip annotation is used with the services. Since a given advertisement has the related peers as fields, the right place to squash is when we manage the advertisements related to a given neighbor. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira cherry-pick OCPBUGS-33365 |
@fedepaol: Jira Issue OCPBUGS-33365 has been cloned as Jira Issue OCPBUGS-33759. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@fedepaol: This pull request references Jira Issue OCPBUGS-33759, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@fedepaol: This pull request references Jira Issue OCPBUGS-33759, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label backport-risk-assessed |
/lgtm |
/retitle [release-4.13] OCPBUGS-33759: FRR: squash advertisements with the same prefix |
}, | ||
}, | ||
{ | ||
name: "mismatch localpref", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't we want to test "mismatch IPFamily" as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but this is a backport, so we don't normally change the content as it was already reviewed and approved upstream and in the various openshift versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than that, didn't notice it's a backport
@fedepaol: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label cherry-pick-approved |
c1e873f
into
openshift:release-4.13
@fedepaol: Jira Issue OCPBUGS-33759: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33759 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.12 |
@fedepaol: #174 failed to apply on top of branch "release-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-metallb-container-v4.13.0-202405161336.p0.gc1e873f.assembly.stream.el8 for distgit ose-metallb. |
Passing multiple advertisements with the same prefix to the template causes duplicate entries. This happens for example when the shared ip annotation is used with the services.
Since a given advertisement has the related peers as fields, the right place to squash is when we manage the advertisements related to a given neighbor.