Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-601 create_pr.py: get base branch from job's name #1237

Closed

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jan 9, 2023

Based on job environment variables:

...
JOB_NAME=periodic-ci-openshift-microshift-main-periodics-rebase-on-nightlies
...

Tested in python's repl:

>>> import re
>>> re.search("periodic-ci-openshift-microshift-(.+)-periodics-rebase-on-nightlies", "periodic-ci-openshift-microshift-main-periodics-rebase-on-nightlies").group(1)
'main'

>>> re.search("periodic-ci-openshift-microshift-(.+)-periodics-rebase-on-nightlies", "periodic-ci-openshift-microshift-release-4.12-periodics-rebase-on-nightlies").group(1)
'release-4.12'

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from copejon and sallyom January 9, 2023 16:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@pmtk
Copy link
Member Author

pmtk commented Jan 9, 2023

/test verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk
Copy link
Member Author

pmtk commented Jan 10, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2023
@openshift-merge-robot
Copy link
Contributor

@pmtk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member Author

pmtk commented Jan 11, 2023

Obsoleted by #1242 and #1245

@pmtk pmtk closed this Jan 11, 2023
@pmtk pmtk deleted the create-pr-detect-base-branch-from-job-name branch March 29, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants