Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-5537: USHIFT-601 rebase: entrypoint and create_pr.py #1242

Merged
merged 1 commit into from Jan 10, 2023

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jan 10, 2023

Because steps in "steps registry" are shared between branches I'd like to move rebase's commands.sh contents into microshift repository so that changes to the job are contained to specific branch.
Otherwise, when introducing rebase.py (wrapper for rebase.sh with extra goodies, will obsolete create_pr.py) will need either introducing into 4.12 branch (and I'd like to run in on main first, as a testing area) or special login in step's commands.sh.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@pmtk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

USHIFT-601: rebase: entrypoint and create_pr.py changes for 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@pmtk pmtk changed the title USHIFT-601: rebase: entrypoint and create_pr.py changes for 4.12 OCPBUGS-5538 USHIFT-601: rebase: entrypoint and create_pr.py changes for 4.12 Jan 10, 2023
@pmtk
Copy link
Member Author

pmtk commented Jan 10, 2023

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@pmtk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-5538 USHIFT-601: rebase: entrypoint and create_pr.py changes for 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@pmtk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member Author

pmtk commented Jan 10, 2023

/jira refresh

@openshift-ci-robot
Copy link

@pmtk: No Jira bug is referenced in the title of this pull request.
To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk changed the title OCPBUGS-5538 USHIFT-601: rebase: entrypoint and create_pr.py changes for 4.12 OCPBUGS-5538: USHIFT-601 rebase: entrypoint and create_pr.py changes for 4.12 Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@pmtk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-5538: USHIFT-601 rebase: entrypoint and create_pr.py changes for 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-5538, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set
  • expected Jira Issue OCPBUGS-5538 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Because steps in "steps registry" are shared between branches I'd like to move rebase's commands.sh contents into microshift repository so that changes to the job are contained to specific branch.
Otherwise, when introducing rebase.py (wrapper for rebase.sh with extra goodies, will obsolete create_pr.py) will need either introducing into 4.12 branch (and I'd like to run in on main first, as a testing area) or special login in step's commands.sh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 10, 2023
@pmtk
Copy link
Member Author

pmtk commented Jan 10, 2023

/jira refresh

@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-5538, which is invalid:

  • expected the bug to target the "4.12.0" version, but it targets "4.12" instead
  • expected dependent Jira Issue OCPBUGS-5537 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead
  • expected dependent Jira Issue OCPBUGS-5537 to target a version in 4.13.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk changed the base branch from release-4.12 to main January 10, 2023 10:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@pmtk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-5538: USHIFT-601 rebase: entrypoint and create_pr.py changes for 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-5538, which is invalid:

  • expected the bug to target the "4.12.0" version, but it targets "4.12" instead
  • expected dependent Jira Issue OCPBUGS-5537 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead
  • expected dependent Jira Issue OCPBUGS-5537 to target a version in 4.13.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Because steps in "steps registry" are shared between branches I'd like to move rebase's commands.sh contents into microshift repository so that changes to the job are contained to specific branch.
Otherwise, when introducing rebase.py (wrapper for rebase.sh with extra goodies, will obsolete create_pr.py) will need either introducing into 4.12 branch (and I'd like to run in on main first, as a testing area) or special login in step's commands.sh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk changed the title OCPBUGS-5538: USHIFT-601 rebase: entrypoint and create_pr.py changes for 4.12 OCPBUGS-5537: USHIFT-601 rebase: entrypoint and create_pr.py Jan 10, 2023
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-5537, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Because steps in "steps registry" are shared between branches I'd like to move rebase's commands.sh contents into microshift repository so that changes to the job are contained to specific branch.
Otherwise, when introducing rebase.py (wrapper for rebase.sh with extra goodies, will obsolete create_pr.py) will need either introducing into 4.12 branch (and I'd like to run in on main first, as a testing area) or special login in step's commands.sh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member Author

pmtk commented Jan 10, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2023
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-5537, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo January 10, 2023 10:28
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@pmtk
Copy link
Member Author

pmtk commented Jan 10, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot

@pmtk: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 398eee7 into openshift:main Jan 10, 2023
@openshift-ci-robot
Copy link

@pmtk: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5537 has been moved to the MODIFIED state.

In response to this:

Because steps in "steps registry" are shared between branches I'd like to move rebase's commands.sh contents into microshift repository so that changes to the job are contained to specific branch.
Otherwise, when introducing rebase.py (wrapper for rebase.sh with extra goodies, will obsolete create_pr.py) will need either introducing into 4.12 branch (and I'd like to run in on main first, as a testing area) or special login in step's commands.sh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@pmtk: new pull request created: #1245

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants