Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-11967: Use ovn-k masquerade nexthop address as gateway route's default gw #1775

Merged
merged 1 commit into from
May 11, 2023

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented May 9, 2023

With this change, the gateway router of ovn-k can always forward egress traffic to host kernel.

It will fix the following scenarios:

  1. no default gateway host
  2. the connection to host default gateway is down

Which issue(s) this PR addresses:

Closes #

With this change, the gateway router of ovn-k can always forward
egress traffic to host kernel.

It will fix the following scenarios:
1. no default gateway host
2. the connection to host default gateway is down

Signed-off-by: Peng Liu <pliu@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 9, 2023
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-11967, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

With this change, the gateway router of ovn-k can always forward egress traffic to host kernel.

It will fix the following scenarios:

  1. no default gateway host
  2. the connection to host default gateway is down

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 9, 2023
@openshift-ci openshift-ci bot requested review from jogeo, dhellmann and pmtk May 9, 2023 15:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@jogeo
Copy link
Contributor

jogeo commented May 9, 2023

/cc @anuragthehatter

@dhellmann
Copy link
Contributor

This change looks good to me.

I see that @jogeo asked @anuragthehatter to look at it, is that for pre-merge testing?

@zshi-redhat
Copy link
Contributor

LGTM

@zshi-redhat
Copy link
Contributor

/test microshift-e2e-arm

@pliurh
Copy link
Contributor Author

pliurh commented May 11, 2023

/retest

@dhellmann
Copy link
Contributor

/lgtm

@dhellmann
Copy link
Contributor

/cherry-pick release-4.13

@openshift-cherrypick-robot

@dhellmann: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6774165 and 2 for PR HEAD 18adc8a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

@pliurh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e-arm 18adc8a link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9ea8dea into openshift:main May 11, 2023
7 of 8 checks passed
@openshift-ci-robot
Copy link

@pliurh: Jira Issue OCPBUGS-11967: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11967 has been moved to the MODIFIED state.

In response to this:

With this change, the gateway router of ovn-k can always forward egress traffic to host kernel.

It will fix the following scenarios:

  1. no default gateway host
  2. the connection to host default gateway is down

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@dhellmann: new pull request created: #1791

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants