Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-13548: Use ovn-k masquerade nexthop address as gateway route's default gw #1791

Merged
merged 1 commit into from
May 18, 2023
Merged

[release-4.13] OCPBUGS-13548: Use ovn-k masquerade nexthop address as gateway route's default gw #1791

merged 1 commit into from
May 18, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1775

/assign dhellmann

@pliurh
Use ovn-k masquerade nexthop address as gateway route's default gw
86f371a 
With this change, the gateway router of ovn-k can always forward
egress traffic to host kernel.

It will fix the following scenarios:
1. no default gateway host
2. the connection to host default gateway is down

Signed-off-by: Peng Liu <pliu@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 11, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11967 has been cloned as Jira Issue OCPBUGS-13548. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-13548: Use ovn-k masquerade nexthop address as gateway route's default gw

In response to this:

This is an automated cherry-pick of #1775

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-11967: Use ovn-k masquerade nexthop address as gateway route's default gw [release-4.13] OCPBUGS-13548: Use ovn-k masquerade nexthop address as gateway route's default gw May 11, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label May 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-13548: Use ovn-k masquerade nexthop address as gateway route's default gw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 11, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-13548, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11967 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-11967 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1775

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jogeo, pmtk and sallyom May 11, 2023 15:58
@dhellmann
Copy link
Contributor

The conformance-reduced job failed with

Updating Subscription Management repositories.
Last metadata expiration check: 0:00:07 ago on Thu 11 May 2023 04:25:53 PM UTC.
No match for argument: firewalld
Error: Unable to find a match: firewalld

@pacevedom this is a 4.13 change, do we need to update that job to use the right AMI separately from the job on main?

/retest-required

@ggiguash
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 13, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2023
@ggiguash
Copy link
Contributor

/retest-required

@dhellmann
Copy link
Contributor 

sudo dnf install -y firewalld
Updating Subscription Management repositories.
Last metadata expiration check: 0:00:07 ago on Sat 13 May 2023 05:24:29 AM UTC.
No match for argument: firewalld
Error: Unable to find a match: firewalld

/retest-required

@ggiguash
Copy link
Contributor

/retest

@jogeo
Copy link
Contributor

jogeo commented May 18, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 18, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD df34819 and 2 for PR HEAD 86f371a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 86f371a link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e2287f0 into openshift:release-4.13 May 18, 2023
13 of 14 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13548: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13548 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1775

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@pmtk pmtk Awaiting requested review from pmtk

@sallyom sallyom Awaiting requested review from sallyom

Assignees

@dhellmann dhellmann

@mffiedler mffiedler

@jhou1 jhou1

@zhaozhanqi zhaozhanqi

@jogeo jogeo

@xingxingxia xingxingxia

@anuragthehatter anuragthehatter

@wangke19 wangke19

@pacevedom pacevedom

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet