Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19457: Test update from current release #2292

Merged
merged 1 commit into from
Sep 30, 2023
Merged

OCPBUGS-19457: Test update from current release #2292

merged 1 commit into from
Sep 30, 2023

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Sep 1, 2023 •
edited by openshift-ci bot

Closes: USHIFT-1097 USHIFT-1107 OCPBUGS-19457

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 1, 2023 •
edited by openshift-ci bot

@pmtk: This pull request references USHIFT-1107 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2023
@pmtk
Copy link
Member Author

pmtk commented Sep 1, 2023

/test microshift-metal-tests

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
dhellmann
dhellmann reviewed Sep 1, 2023
View reviewed changes
test/bin/build_images.sh Outdated Show resolved Hide resolved
test/bin/build_images.sh Outdated Show resolved Hide resolved
@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch from b5df017 to a4e7f46 Compare September 1, 2023 18:01
@pmtk
Copy link
Member Author

pmtk commented Sep 1, 2023

/test microshift-metal-tests

@pmtk
Copy link
Member Author

pmtk commented Sep 2, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2023

@pmtk: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test microshift-metal-tests
  • /test test-srpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test microshift-metal-tests-arm
  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member Author

pmtk commented Sep 2, 2023

/test metal-periodic-test

@pmtk
Copy link
Member Author

pmtk commented Sep 4, 2023

Until new EC/RC, the tests will fail/work incorrectly:

"FAIL reading version file" err="unmarshalling \"4.14.0\" failed: invalid character '.' after top-level value"

@dhellmann
Copy link
Contributor

@pmtk are we going to have an issue with this test for the first sprint of every release before there is an EC for the current version?

@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch from a4e7f46 to 7e37549 Compare September 12, 2023 13:28
@pmtk
Copy link
Member Author

pmtk commented Sep 12, 2023

@pmtk are we going to have an issue with this test for the first sprint of every release before there is an EC for the current version?

Because the source/blueprint are optional if we cannot determine the version, it should work.

@pmtk
Copy link
Member Author

pmtk commented Sep 12, 2023

/test metal-periodic-test

@pmtk pmtk marked this pull request as ready for review September 13, 2023 12:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch 3 times, most recently from 8868a5b to f23fa79 Compare September 13, 2023 15:30
@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch from f23fa79 to 0688e9b Compare September 14, 2023 15:06
@pmtk
Copy link
Member Author

pmtk commented Sep 14, 2023

I moved the gomplate POC to separate PR: #2351
Let's decide if we want to utilize gomplate for this (looks nice)

@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch 2 times, most recently from 87386f7 to 5a81ebd Compare September 20, 2023 12:09
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023 •
edited by openshift-ci bot

@pmtk: This pull request references USHIFT-1107 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Closes: USHIFT-1097 USHIFT-1107 OCPBUGS-19457

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023 •
edited by openshift-ci bot

@pmtk: This pull request references USHIFT-1107 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Closes: USHIFT-1097 USHIFT-1107 OCPBUGS-19457

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk changed the title USHIFT-1097 USHIFT-1107: Test update from current release OCPBUGS-19457: Test update from current release Sep 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 20, 2023
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-19457, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: USHIFT-1097 USHIFT-1107 OCPBUGS-19457

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch from 5a81ebd to 57eaf39 Compare September 20, 2023 13:00
@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch 2 times, most recently from 31a7033 to f8cf89b Compare September 27, 2023 14:46
@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e2ca326 and 2 for PR HEAD f8cf89b in total

@pmtk
Copy link
Member Author

pmtk commented Sep 29, 2023

/test microshift-metal-tests

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 00b44ba and 1 for PR HEAD f8cf89b in total

@pmtk pmtk force-pushed the 1097-1107-update-from-current-release branch from f8cf89b to 1646dcd Compare September 29, 2023 16:48
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-19457, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

Closes: USHIFT-1097 USHIFT-1107 OCPBUGS-19457

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 00b44ba and 2 for PR HEAD 1646dcd in total

@pmtk
Copy link
Member Author

pmtk commented Sep 30, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2023

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c736284 into openshift:main Sep 30, 2023
5 checks passed
@openshift-ci-robot
Copy link

@pmtk: Jira Issue OCPBUGS-19457: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19457 has been moved to the MODIFIED state.

In response to this:

Closes: USHIFT-1097 USHIFT-1107 OCPBUGS-19457

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk deleted the 1097-1107-update-from-current-release branch December 15, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@copejon copejon Awaiting requested review from copejon

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@eggfoobar eggfoobar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pmtk @openshift-ci-robot @dhellmann @eggfoobar @openshift-merge-robot