OCPBUGS-19384: Use gomplate templating engine

[pmtk]

No description provided.

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-1546 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[pmtk]

/test microshift-metal-tests

[pmtk]

/cc @dhellmann

[pmtk]

Putting on hold because to get this to 4.14, we need OCPBUGS tickets
/hold

[pmtk]

/test ?

[openshift-ci]

@pmtk: The following commands are available to trigger required jobs:

• /test images
• /test metal-periodic-test
• /test microshift-metal-tests
• /test test-srpm
• /test test-unit
• /test verify

The following commands are available to trigger optional jobs:

• /test microshift-metal-tests-arm
• /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-microshift-main-images
• pull-ci-openshift-microshift-main-microshift-metal-tests
• pull-ci-openshift-microshift-main-test-unit
• pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pmtk]

/test metal-periodic-test

[dhellmann]

This looks like a good change. The tool offers some options for passing inputs, so we could consider moving some values out of environment variables into a config file if that would make anything easier. There are some other types of files that use sed for replacing values (the kickstart templates are the main ones that come to mind), and we should convert those, too, but that can happen in another PR.

What does the team think about when to merge this?

[pmtk]

This looks like a good change. The tool offers some options for passing inputs, so we could consider moving some values out of environment variables into a config file if that would make anything easier. There are some other types of files that use sed for replacing values (the kickstart templates are the main ones that come to mind), and we should convert those, too, but that can happen in another PR.

What does the team think about when to merge this?

I kept envvars so when we backport the change to 4.14, it doesn't change too much.
For 4.15 onwards, I'd definitely would try to ditch the envvars and use some explicit args instead

[openshift-ci-robot]

@pmtk: This pull request references Jira Issue OCPBUGS-19384, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pmtk]

/unhold

[pacevedom]

a nice addition that allows more complex logic, will hold to allow others to take a look/review.
/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pacevedom,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/unhold

Looks great, thanks @pmtk !

[pmtk]

/cherrypick release-4.14

[openshift-cherrypick-robot]

@pmtk: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD bcdcf64 and 2 for PR HEAD c4e2526 in total

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@pmtk: Jira Issue OCPBUGS-19384: All pull requests linked via external trackers have merged:

• openshift/microshift#2351

Jira Issue OCPBUGS-19384 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@pmtk: new pull request created: #2371

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.