Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-1737: fix: add wait for microshift serice to make sure health check succeeds #2412

Merged
merged 2 commits into from Oct 2, 2023

Conversation

eggfoobar
Copy link
Contributor

Seems like we might have a timing problem between when the teardown of kustomize happens and when we validate microshift is up

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@eggfoobar
Copy link
Contributor Author

/retest-required

1 similar comment
@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar eggfoobar changed the title fix: add wait for microshift serice to make sure health check succeeds USHIFT-1737: fix: add wait for microshift serice to make sure health check succeeds Oct 2, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023

@eggfoobar: This pull request references USHIFT-1737 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Seems like we might have a timing problem between when the teardown of kustomize happens and when we validate microshift is up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023

@eggfoobar: This pull request references USHIFT-1737 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Seems like we might have a timing problem between when the teardown of kustomize happens and when we validate microshift is up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,eggfoobar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d7cbeab into openshift:main Oct 2, 2023
4 checks passed
@dhellmann
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot

@dhellmann: #2412 failed to apply on top of branch "release-4.14":

Applying: fix: add wait for microshift serice to make sure health check succeeds
Using index info to reconstruct a base tree...
M	test/suites/standard/kustomize.robot
Falling back to patching base and 3-way merge...
Auto-merging test/suites/standard/kustomize.robot
CONFLICT (content): Merge conflict in test/suites/standard/kustomize.robot
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: add wait for microshift serice to make sure health check succeeds
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants