Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-20044: Cherry pick 2403 2412 2425 #2431

Merged
merged 5 commits into from
Oct 4, 2023
Merged

[release-4.14] OCPBUGS-20044: Cherry pick 2403 2412 2425 #2431

merged 5 commits into from
Oct 4, 2023

Conversation

eggfoobar
Copy link
Contributor

Cherrypicking #2403 #2412 #2425

/cc @ggiguash
/assign @pacevedom

eggfoobar and others added 5 commits October 3, 2023 10:15
@eggfoobar
feat: re-add /usr/lib check for kustomize
b3b3b57 
added logic to make /usr/lib writable during test, rebooting will revert back to immutable filesystem

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
fix: add wait for microshift serice to make sure health check succeeds
38e0ca7 
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
feat: moved wait for microshift service inside wait for microshift
11cf93c 
Signed-off-by: ehila <ehila@redhat.com>
@pmtk @eggfoobar
re-enable microshift.service after cleanup
0255b5a
@eggfoobar
altered to get kubeconfig after hostname change
129700a 
added setup kubeconfig keyword to get new potential kubeconfig after
microshift start

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 3, 2023
@openshift-ci openshift-ci bot requested a review from ggiguash October 3, 2023 14:45
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023 •
edited by openshift-ci bot

@eggfoobar: This pull request references Jira Issue OCPBUGS-20044, which is invalid:

  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • bug has dependents
  • dependent bug USHIFT-1705 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherrypicking #2403 #2412 #2425

/cc @ggiguash
/assign @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023 •
edited by openshift-ci bot

@eggfoobar: This pull request references Jira Issue OCPBUGS-20044, which is invalid:

  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • bug has dependents
  • dependent bug USHIFT-1705 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Cherrypicking #2403 #2412 #2425

/cc @ggiguash
/assign @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@eggfoobar: This pull request references Jira Issue OCPBUGS-20044, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20045 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead
  • expected dependent Jira Issue OCPBUGS-20045 to target a version in 4.15.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 3, 2023
@openshift-ci-robot
Copy link

@eggfoobar: This pull request references Jira Issue OCPBUGS-20044, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20045 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-20045 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@eggfoobar: This pull request references Jira Issue OCPBUGS-20044, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20045 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-20045 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

In response to this:

Cherrypicking #2403 #2412 #2425

/cc @ggiguash
/assign @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo October 3, 2023 14:52
@eggfoobar
Copy link
Contributor Author

/test microshift-metal-tests

@dhellmann
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,eggfoobar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhensel-rh
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 4, 2023
@openshift-ci openshift-ci bot merged commit d0794fe into openshift:release-4.14 Oct 4, 2023
4 checks passed
@openshift-ci-robot
Copy link

@eggfoobar: Jira Issue OCPBUGS-20044: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20044 has been moved to the MODIFIED state.

In response to this:

Cherrypicking #2403 #2412 #2425

/cc @ggiguash
/assign @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@dhellmann dhellmann

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eggfoobar @openshift-ci-robot @dhellmann @dhensel-rh @pacevedom @pmtk