AUTH-296: Cut off the root CA from the cluster-distributed client CA #949
Conversation
|
It appears that MicroShift is crashing during the boot phase, but the stack trace is overflowing the output here, which makes it hard to understand what's causing it. |
|
I've create the dev environment to debug. Looks like the logic writes two certificates into the CSR signer cert file, which Kube does not seem to like. I'll fix this. |
|
The latest patch should make the KCM start again |
|
/test periodics-images |
|
/test e2e-openshift-conformance-sig-api-machinery |
|
|
|
/test all |
The current cert creation tooling might be confused if we did not provide a service name. I'm supplying "remove-this" as this code should be refactored soon.A The current cert creation tooling might be confused if we did not provide a service name. I'm supplying "remove-this" as this code should be refactored soon.
| "tls.crt", "tls.key", | ||
| []string{"system:admin", "system:masters"}); err != nil { | ||
| []string{"remove-this"}); err != nil { |
There was a problem hiding this comment.
I'm not understanding this. Are you including "remove-this" in order to remember that we have to refactor this piece of code?
There was a problem hiding this comment.
Exactly, in fact, this piece of code goes away with #951
There was a problem hiding this comment.
Ok, I'd have prefered a // TODO: comment, but since it's going away in the next PR, I'm ok with it.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oglok, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-rpm-install |
|
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR makes the following changes: