Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-296: Cut off the root CA from the cluster-distributed requestheader-client-ca #951

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Sep 14, 2022

This PR narrows the trust for the requestheader-client-ca distributed in the cluster in the kube-system/extension-apiserver-authentication CM.

/cc @oglok @ibihim

@stlaz
Copy link
Member Author

stlaz commented Sep 14, 2022

/retest

Copy link
Contributor

@oglok oglok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok, but why isn't there any aggregator signer in OpenShift? Why is this case different?

https://github.com/openshift/api/blob/master/tls/docs/kube-apiserver%20Client%20Certificates/README.md#admin-kubeconfig-signer

pkg/cmd/init.go Show resolved Hide resolved
@stlaz
Copy link
Member Author

stlaz commented Sep 19, 2022

/test e2e-rpm-install

@oglok
Copy link
Contributor

oglok commented Sep 19, 2022

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2022
@oglok
Copy link
Contributor

oglok commented Sep 19, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oglok, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2022

@stlaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a7c3bdd into openshift:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants