Improve synthetic metrics and include rules #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve synthetic metrics by producing simple histogram data that very rougly approximates the lifecycle data we want to measure. Incorporate some example rules to be automatically read by Prometheus, including an example alert which will start firing soon after startup.
|
Note that the histogram buckets, histogram query, and alert rule are pretty contrived and probably poorly conceived along a variety of dimensions. My goal here is to flesh out the integration story first, and solidify the specific metric/alert characteristics later. |
twiest
added a commit
that referenced
this pull request
Apr 11, 2018
Change hard coded values to config file values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve synthetic metrics by producing simple histogram data that very rougly
approximates the lifecycle data we want to measure. Incorporate some example
rules to be automatically read by Prometheus, including an example alert which
will start firing soon after startup.