New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes configuration invalidation #50
Removes configuration invalidation #50
Conversation
/test all |
/retest |
2 similar comments
/retest |
/retest |
/retest There's a very good chance that this fixed the openshift-apiserver going unavailable during upgrades (https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_multus-cni/50/pull-ci-openshift-multus-cni-master-e2e-aws-upgrade/77) - since that test has consistently failed since it was introduced, but it's passed here. Which is excellent news - @deads2k were there any other changes landed in the last few days that could have made this start passing, or can we infer causation from this change? |
/retest |
This time the api was down for only 11s, which is a big improvement. I think this passes the bar for me "value in coasting" > "slightly complexity increase of cleaning up". So I'm supportive of this going into 4.5, us assessing it, and then back porting after a few days/week of improvement. |
/retest |
It looks like the upgrade is broken at 79% and multus container is crash looping:
|
8147dae
to
6911259
Compare
Thanks for the eyes on the shell script error. I've got a new commit up that should address that. If this look OK with this one, I'll put together a final product that can go both upstream/downstream. |
I'm going to run an upgrade job in the reverse order (from this PR to master) to see that it fixes the disruption (since the current path won't because we upgrade from not this code to having this code and the check is on teardown). |
/test images |
2 similar comments
/test images |
/test images |
Ok, https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/19234/build-log.txt (in https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/19234) looks like it successfully met the criteria (node didn't go notready during multus upgrade). This improves the outcome of upgrade by reducing unrelated failures, so lgtm in terms of approach (still needs code review). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
Do we need to change this code? Can't we just set |
/hold for the question |
As far as I look the code, following line does not have "if $MULTUS_CLEANUP_CONFIG_ON_EXIT" so need to modify diffs to keep the flag. https://github.com/openshift/multus-cni/pull/50/files#diff-5b59de2786d0584351695a727ff60b59L389-L392 |
Two parts to the cleanup, invalidating the config (which this commit removes) and the other -- regenerating the config after an sdn upgrade (which this does not remove) so... I recommend we move forward with what's here (ok to merge but we'll need to sync with upstream later) |
6911259
to
50da638
Compare
/title Removes configuration invalidation |
/lgtm |
/retitle Removes configuration invalidation |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
Experimental commit, do not merge. Hacks in method for not removing config invalidation.