Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds readinessindicatorfile check on CNI DEL #54

Merged
merged 1 commit into from Apr 2, 2020
Merged

Adds readinessindicatorfile check on CNI DEL #54

merged 1 commit into from Apr 2, 2020

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Mar 27, 2020

This adds the readiness check on CNI DEL.

This is a WIP until I can have some maintainers discussion about it, as well.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@dougbtv
Copy link
Member Author

dougbtv commented Mar 27, 2020

/test upgrade #54

@smarterclayton
Copy link

Running an upgrade test on this with both sides of the PR https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/23818

@danehans
Copy link

danehans commented Apr 1, 2020

/cherrypick release-4.4

This is a test to see if this PR fixes failed 4.4 GCP upgrade CI jobs.

@openshift-cherrypick-robot
Copy link

@danehans: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

This is a test to see if this PR fixes failed 4.4 GCP upgrade CI jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2020
@dougbtv
Copy link
Member Author

dougbtv commented Apr 2, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2020
@dougbtv
Copy link
Member Author

dougbtv commented Apr 2, 2020

/retitle Adds readinessindicatorfile check on CNI DEL

s1061123
s1061123 approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot changed the title [WIP] Adds readinessindicatorfile check on CNI DEL Adds readinessindicatorfile check on CNI DEL Apr 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 25d0d0a into openshift:master Apr 2, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 2, 2020
Merged
@openshift-cherrypick-robot
Copy link

@danehans: new pull request created: #56

In response to this:

/cherrypick release-4.4

This is a test to see if this PR fixes failed 4.4 GCP upgrade CI jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougbtv
Copy link
Member Author

dougbtv commented Apr 3, 2020

/retest

@dougbtv dougbtv mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 s1061123 approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@fepan fepan Awaiting requested review from fepan

Assignees

@s1061123 s1061123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dougbtv @smarterclayton @danehans @openshift-cherrypick-robot @openshift-ci-robot @openshift-bot @s1061123 @openshift-merge-robot