Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDCICD-1286] Set SSS mode to Upsert as prep for RVMO adoption #142

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

mmazur
Copy link
Member

@mmazur mmazur commented Jul 3, 2024

Must Gather Operator is the first operator being switched from being deployed directly to hives using its own SelectorSyncSet to being deployed as part of the release bundle (managed-release-bundle-osd.git, SDE-3672).

First step is to switch the current SelectorSyncSet to Upsert mode, which will allow deleting the SelectorSyncSet entirely without Hives messing up any MGO deployments on clusters.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.75%. Comparing base (ffba798) to head (479addf).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   37.75%   37.75%           
=======================================
  Files           5        5           
  Lines         392      392           
=======================================
  Hits          148      148           
  Misses        241      241           
  Partials        3        3           

@mmazur
Copy link
Member Author

mmazur commented Jul 3, 2024

/test validate

@mmazur
Copy link
Member Author

mmazur commented Jul 3, 2024

/retest validate

Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@mmazur: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test coverage
  • /test images
  • /test lint
  • /test test
  • /test validate

Use /test all to run all jobs.

In response to this:

/retest validate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmazur
Copy link
Member Author

mmazur commented Jul 3, 2024

/retest

@mmazur
Copy link
Member Author

mmazur commented Jul 3, 2024

Seems something's wrong with prow, the test passed not long ago.

Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, mmazur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ffba798 and 2 for PR HEAD 479addf in total

@mmazur
Copy link
Member Author

mmazur commented Jul 3, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@mmazur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3a02382 into openshift:master Jul 3, 2024
6 checks passed
@mmazur mmazur deleted the upsssert branch July 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants