Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1829113: Add openshift-kni-infra namespace to gather #150

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

cybertron
Copy link
Member

openshift-kni-infra is the namespace where baremetal service pods
run. Currently it is not collected by must-gather which can make it
difficult to debug baremetal deployment issues. This adds the
namespace to the list of namespaces from which to collect logs.

openshift-kni-infra is the namespace where baremetal service pods
run. Currently it is not collected by must-gather which can make it
difficult to debug baremetal deployment issues. This adds the
namespace to the list of namespaces from which to collect logs.
@cybertron
Copy link
Member Author

/retest

@cybertron
Copy link
Member Author

/assign @sferich888

@sferich888
Copy link
Contributor

/lgtm

I'm not sure why this is needed but it's fine to add, generally we want to add resources (types) so that if they exist in other places we get them in those namespaces too.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@cybertron
Copy link
Member Author

These are static pods deployed on each node by machine-config-operator. Is there a better way to include that sort of thing in must-gather?

@runcom
Copy link
Member

runcom commented Apr 29, 2020

@cybertron please update the title here to reference https://bugzilla.redhat.com/show_bug.cgi?id=1829113

@cybertron cybertron changed the title Add openshift-kni-infra namespace to gather Bug 1829113: Add openshift-kni-infra namespace to gather Apr 30, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 30, 2020
@openshift-ci-robot
Copy link

@cybertron: This pull request references Bugzilla bug 1829113, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1829113: Add openshift-kni-infra namespace to gather

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 74bea3c into openshift:master Apr 30, 2020
@openshift-ci-robot
Copy link

@cybertron: All pull requests linked via external trackers have merged: openshift/must-gather#150. Bugzilla bug 1829113 has been moved to the MODIFIED state.

In response to this:

Bug 1829113: Add openshift-kni-infra namespace to gather

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants