-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1829113: Add openshift-kni-infra namespace to gather #150
Conversation
openshift-kni-infra is the namespace where baremetal service pods run. Currently it is not collected by must-gather which can make it difficult to debug baremetal deployment issues. This adds the namespace to the list of namespaces from which to collect logs.
/retest |
/assign @sferich888 |
/lgtm I'm not sure why this is needed but it's fine to add, generally we want to add resources (types) so that if they exist in other places we get them in those namespaces too. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, sferich888 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These are static pods deployed on each node by machine-config-operator. Is there a better way to include that sort of thing in must-gather? |
@cybertron please update the title here to reference https://bugzilla.redhat.com/show_bug.cgi?id=1829113 |
@cybertron: This pull request references Bugzilla bug 1829113, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@cybertron: All pull requests linked via external trackers have merged: openshift/must-gather#150. Bugzilla bug 1829113 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-kni-infra is the namespace where baremetal service pods
run. Currently it is not collected by must-gather which can make it
difficult to debug baremetal deployment issues. This adds the
namespace to the list of namespaces from which to collect logs.