Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1877428: Update gather_core_dumps to get raw coredump files #173

Merged
merged 1 commit into from Sep 9, 2020
Merged

Bug 1877428: Update gather_core_dumps to get raw coredump files #173

merged 1 commit into from Sep 9, 2020

Conversation

astoycos
Copy link
Contributor

The previous iteration of gather_core_dumps used
coredumpsctl info to get information

It was shown that we in fact need the raw coredump
files for debugging

This PR extracts corefiles from the nodes by

  1. Forcing a Debug pod to stay open on node
  2. Waiting for the Debug pod to run
  3. Using oc cp to extract the necessary files

TODO: find a way to do this without forcing the
debug pod to stay running

Signed-off-by: Andrew Stoycos astoycos@redhat.com

@astoycos
Copy link
Contributor Author

@trozet

@astoycos
Copy link
Contributor Author

/retest

1 similar comment
@astoycos
Copy link
Contributor Author

/retest

trozet
trozet suggested changes Aug 31, 2020
View reviewed changes
collection-scripts/gather_core_dumps Outdated Show resolved Hide resolved
collection-scripts/gather_core_dumps Outdated Show resolved Hide resolved
collection-scripts/gather_core_dumps Outdated Show resolved Hide resolved
@astoycos
Copy link
Contributor Author

/retest

trozet
trozet suggested changes Sep 1, 2020
View reviewed changes
collection-scripts/gather_core_dumps Outdated Show resolved Hide resolved
@astoycos
Copy link
Contributor Author

astoycos commented Sep 1, 2020

/assign @RickJWagner

trozet
trozet approved these changes Sep 1, 2020
View reviewed changes
Copy link

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@astoycos astoycos requested a review from trozet September 1, 2020 21:12
@astoycos astoycos mentioned this pull request Sep 2, 2020
Merged
@astoycos
Update gather_core_dumps to get raw coredumps
b72263f 
The previous iteration of `gather_core_dumps` used
`coredumpsctl info` to get information

It was shown that we in fact need the raw coredump
files for debugging

This PR extracts corefiles from the nodes by
1. Forcing a Debug pod to stay open on node
2. Waiting for the Debug pod to run
3. Using `oc cp` to extract the necessary files

It does the node dump collection in
parallel to increase efficiency

TODO:
find a way to do this without forcing the
debug pod to stay running
Add parellel running method to other network
log collection scripts

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@astoycos
Copy link
Contributor Author

astoycos commented Sep 4, 2020

@rbbratta should be all good now

@trozet
Copy link

trozet commented Sep 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@davemulford
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@astoycos astoycos changed the title Update gather_core_dumps to get raw coredump files Bug 1877428: Update gather_core_dumps to get raw coredump files Sep 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 9, 2020
@openshift-ci-robot
Copy link

@astoycos: This pull request references Bugzilla bug 1877428, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1877428: Update gather_core_dumps to get raw coredump files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 9, 2020
@astoycos
Copy link
Contributor Author

astoycos commented Sep 9, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@astoycos: This pull request references Bugzilla bug 1877428, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JacobTanenbaum
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 9, 2020
@openshift-ci-robot
Copy link

@JacobTanenbaum: This pull request references Bugzilla bug 1877428, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 9, 2020
@davemulford
Copy link

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, davemulford, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4ebaa52 into openshift:master Sep 9, 2020
@openshift-ci-robot
Copy link

@astoycos: All pull requests linked via external trackers have merged:

Bugzilla bug 1877428 has been moved to the MODIFIED state.

In response to this:

Bug 1877428: Update gather_core_dumps to get raw coredump files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

astoycos added a commit to astoycos/must-gather that referenced this pull request Sep 10, 2020
@astoycos
This Commit fixes the failed validation on PR [173](openshift#173)
2582451 
in response to the [feedback from QA](https://bugzilla.redhat.com/show_bug.cgi?id=1877428)

It updated how the name of the debug pod is
determined

Specifically it uses `sed` to extract the pod name
when the pod is created with `oc debug`
astoycos added a commit to astoycos/must-gather that referenced this pull request Sep 10, 2020
@astoycos
This Commit fixes the failed validation on PR openshift#173
36794f1 
in response to the [feedback from QA](https://bugzilla.redhat.com/show_bug.cgi?id=1877428)

It updated how the name of the debug pod is
determined

Specifically it uses `sed` to extract the pod name
when the pod is created with `oc debug`

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/must-gather that referenced this pull request Sep 11, 2020
@astoycos
This Commit fixes the failed validation on PR openshift#173
7ecfcb8 
in response to the [feedback from QA](https://bugzilla.redhat.com/show_bug.cgi?id=1877428)

It updated how the name of the debug pod is
determined

Specifically it uses `sed` to extract the pod name
when the pod is created with `oc debug`

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/must-gather that referenced this pull request Sep 11, 2020
@astoycos
This Commit fixes the failed validation on PR openshift#173
7324ba3 
in response to the [feedback from QA](https://bugzilla.redhat.com/show_bug.cgi?id=1877428)

It updated how the name of the debug pod is
determined

Specifically it uses `sed` to extract the pod name
when the pod is created with `oc debug`

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@astoycos astoycos mentioned this pull request Sep 11, 2020
Merged
This was referenced Sep 17, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbbratta rbbratta rbbratta left review comments

@davemulford davemulford Awaiting requested review from davemulford

@RickJWagner RickJWagner Awaiting requested review from RickJWagner

@trozet trozet Awaiting requested review from trozet

Assignees

@davemulford davemulford

@RickJWagner RickJWagner

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@astoycos @trozet @davemulford @openshift-ci-robot @JacobTanenbaum @rbbratta @RickJWagner @openshift-merge-robot