Bug 1877428: Update gather_core_dumps collection of debug pod's name, clean up resources #174
Conversation
in response to the [feedback from QA](https://bugzilla.redhat.com/show_bug.cgi?id=1877428) It updated how the name of the debug pod is determined Specifically it uses `sed` to extract the pod name when the pod is created with `oc debug` Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
openshift-ci-robot
added
the
bugzilla/severity-high
|
@astoycos: This pull request references Bugzilla bug 1877428, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
|
/assign @sferich888 |
There was a problem hiding this comment.
@davemulford you did the first review here, do you have issues with this?
|
No issues here, @sferich888! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astoycos, sferich888 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@astoycos: All pull requests linked via external trackers have merged: Bugzilla bug 1877428 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This Commit fixes the failed validation on
PR https://github.com/openshift/must-gather/pull/173`
in response to the feedback from QA
It updated how the name of the debug pod is
determined
Specifically it uses
sedto extract the pod namewhen the pod is created with
oc debugrather thanusing
oc getto try and determine the name after the factsince there is more room for errors in string formatting
Also ensures that the debug pod is delete the moment we
are finished with it rather than allowing it to hang
Signed-off-by: Andrew Stoycos astoycos@redhat.com