Add olm resources to default must-gather #182
Conversation
| for resource in "${resources[@]}"; do | ||
| oc adm inspect --dest-dir must-gather ${resource} | ||
| done | ||
|
|
||
| # Gather optional operator resources from all namespaces |
There was a problem hiding this comment.
IMO this should go into its own script (encase we ever need to add/filter things). Calling it by default from this script is fine (provided the collection is not astronomical amounts of data/information).
collection-scripts/gather
Outdated
| for resource in "${resources[@]}"; do | ||
| oc adm inspect --dest-dir must-gather ${resource} | ||
| done | ||
|
|
||
| # Gather optional operator resources from all namespaces | ||
| oc adm inspect --dest-dir must-gather -A olm |
There was a problem hiding this comment.
-A is limited to what oc versions (we need to make sure we don't back-port this past that point (and this introduce errors/failures in the collection process).
cc: @mfojtik
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, sferich888 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.6 |
|
@sferich888: new pull request created: #242 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We've had some requests for this - it may be controversial, but this seemed as good a place as any to collect feedback.