Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1862643: Collect docker logs from WinEvent log on Windows machines #195

Merged
merged 1 commit into from Dec 2, 2020
Merged

Bug 1862643: Collect docker logs from WinEvent log on Windows machines #195

merged 1 commit into from Dec 2, 2020

Conversation

LorbusChris
Copy link
Member

Use the Get-WinEvent shim on kubelet logs endpoint introduced in
openshift/kubernetes#383 to collect docker
runtime logs from Windows machines.

/cc @sebsoto @aravindhp
/cherry-pick release-4.6

@LorbusChris
Collect docker logs from WinEvent log on Windows machines
6a7ab47 
Use the Get-WinEvent shim on kubelet logs endpoint introduced in
openshift/kubernetes#383 to collect docker
runtime logs from Windows machines.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 30, 2020
@openshift-ci-robot
Copy link

@LorbusChris: This pull request references Bugzilla bug 1862643, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1862643: Collect docker logs from WinEvent log on Windows machines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 30, 2020
aravindhp
aravindhp approved these changes Nov 30, 2020
View reviewed changes
Copy link

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@aravindhp
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 30, 2020
@openshift-ci-robot
Copy link

@aravindhp: This pull request references Bugzilla bug 1862643, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 30, 2020
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@sebsoto
Copy link
Contributor

sebsoto commented Nov 30, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: aravindhp, LorbusChris, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris
Copy link
Member Author

/retest

1 similar comment
@LorbusChris
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@LorbusChris
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 63612a0 into openshift:master Dec 2, 2020
@openshift-ci-robot
Copy link

@LorbusChris: All pull requests linked via external trackers have merged:

Bugzilla bug 1862643 has been moved to the MODIFIED state.

In response to this:

Bug 1862643: Collect docker logs from WinEvent log on Windows machines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Member Author

/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link

@LorbusChris: new pull request created: #197

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp approved these changes

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@sebsoto sebsoto

@aravindhp aravindhp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@LorbusChris @openshift-ci-robot @aravindhp @sebsoto @openshift-bot @openshift-cherrypick-robot @sdodson @openshift-merge-robot