Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1896691: Collect docker logs from WinEvent log on Windows machines #197

Merged
merged 1 commit into from Dec 4, 2020
Merged

[release-4.6] Bug 1896691: Collect docker logs from WinEvent log on Windows machines #197

merged 1 commit into from Dec 4, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #195

/assign LorbusChris

@LorbusChris
Collect docker logs from WinEvent log on Windows machines
91761ad 
Use the Get-WinEvent shim on kubelet logs endpoint introduced in
openshift/kubernetes#383 to collect docker
runtime logs from Windows machines.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1862643 with correct target release. Retitling PR to link to clone:
/retitle [release-4.6] Bug 1896691: Collect docker logs from WinEvent log on Windows machines

In response to this:

[release-4.6] Bug 1862643: Collect docker logs from WinEvent log on Windows machines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1862643: Collect docker logs from WinEvent log on Windows machines [release-4.6] Bug 1896691: Collect docker logs from WinEvent log on Windows machines Dec 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 4, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1896691, which is invalid:

  • expected dependent Bugzilla bug 1862643 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1896691: Collect docker logs from WinEvent log on Windows machines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 4, 2020
@sebsoto
Copy link
Contributor

sebsoto commented Dec 4, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 4, 2020
@openshift-ci-robot
Copy link

@sebsoto: This pull request references Bugzilla bug 1896691, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1862643 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1862643 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 4, 2020
@sdodson
Copy link
Member

sdodson commented Dec 4, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 4, 2020
Merged
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5377c81 into openshift:release-4.6 Dec 4, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1896691 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1896691: Collect docker logs from WinEvent log on Windows machines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemulford davemulford Awaiting requested review from davemulford

@RickJWagner RickJWagner Awaiting requested review from RickJWagner

Assignees

@sdodson sdodson

@LorbusChris LorbusChris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @sebsoto @sdodson @LorbusChris @openshift-merge-robot