Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRKLDS-950: use must-gather since and since time env vars on inspect cmds #400

Merged
merged 1 commit into from
Jan 22, 2024
Merged

WRKLDS-950: use must-gather since and since time env vars on inspect cmds #400

merged 1 commit into from
Jan 22, 2024

Conversation

flavianmissi
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2024 •
edited by openshift-ci bot
Loading

@flavianmissi: This pull request references WRKLDS-950 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
ardaguclu
ardaguclu reviewed Jan 9, 2024
View reviewed changes
collection-scripts/gather Outdated Show resolved Hide resolved
@flavianmissi flavianmissi mentioned this pull request Jan 11, 2024
Merged
@flavianmissi flavianmissi changed the title WIP WRKLDS-950: use must-gather since and since time env vars on inspect cmds WRKLDS-950: use must-gather since and since time env vars on inspect cmds Jan 11, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2024
ardaguclu
ardaguclu reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@ardaguclu ardaguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, other than that it looks good to me. Thanks.

collection-scripts/gather_service_logs_util Outdated Show resolved Hide resolved
collection-scripts/common.sh Outdated Show resolved Hide resolved
@flavianmissi flavianmissi force-pushed the WRKLDS-950 branch 2 times, most recently from 081b16d to 0081591 Compare January 12, 2024 11:49
@ardaguclu
Copy link
Member

LGTM. I'm deferring to @ingvagabund for another set of eyes.

@flavianmissi
Copy link
Member Author

something is still off, holding until I figure it out
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@flavianmissi
Copy link
Member Author

Checked that --since-time works for both node logs (under host_service_logs) and pod logs (under namespaces/.../pod/.../logs/current.log.
--since is a little more complicated - when a duration is given from via the cli as 2h, after calling duration.String() it is formatted as 2h0m0s and oc adm node-logs does takes a duration matching the (+|-)[0-9]+(s|m|h|d) regex. I'm going to have to truncate the duration string to keep its left most part, so in the case of 2h0m0s only 2h would be given as an argument to oc adm node-logs.

@flavianmissi
Copy link
Member Author

flavianmissi commented Jan 12, 2024 •
edited
Loading

fixed format of duration given to oc adm node-logs.
also using lowercase now for the non-env-vars, which seem to be the best practice.
will be pushing the updates in a moment.

@flavianmissi flavianmissi force-pushed the WRKLDS-950 branch 3 times, most recently from c158eea to 474f935 Compare January 12, 2024 14:46
@flavianmissi
Copy link
Member Author

Both flags now work as they should!
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@flavianmissi flavianmissi force-pushed the WRKLDS-950 branch 2 times, most recently from 9cfafb4 to 1ed10df Compare January 16, 2024 15:58
@flavianmissi flavianmissi force-pushed the WRKLDS-950 branch 2 times, most recently from 0c4dd82 to 7ec17f4 Compare January 17, 2024 15:14
@zhouying7780
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot
Loading

@flavianmissi: This pull request references WRKLDS-950 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member Author

@ardaguclu this one is ready to go in!

@ardaguclu
Copy link
Member

Thanks @flavianmissi
/lgtm

@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
soltysh
soltysh approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, flavianmissi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c8fec85 into openshift:master Jan 22, 2024
3 checks passed
@flavianmissi flavianmissi deleted the WRKLDS-950 branch January 22, 2024 14:34
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.16.0-202401221510.p0.gc8fec85.assembly.stream for distgit ose-must-gather.
All builds following this will include this PR.

@zdtsw zdtsw mentioned this pull request Mar 28, 2024
Merged
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 11, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
2be345c 
see: openshift/must-gather#400

TODO: double check when --since got introduced on oc adm inspect
to understand if it's safe to get this also to older releases.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 11, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
7bc3093 
see: openshift/must-gather#400

TODO: double check when --since got introduced on oc adm inspect
to understand if it's safe to get this also to older releases.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi tiraboschi mentioned this pull request Apr 11, 2024
Merged
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 11, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
681d2d2 
see: openshift/must-gather#400

TODO: double check when --since got introduced on oc adm inspect
to understand if it's safe to get this also to older releases.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 15, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
9c5a257 
see: openshift/must-gather#400

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 17, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
34fef4e 
see: openshift/must-gather#400

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 17, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
ec8afc6 
see: openshift/must-gather#400

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 22, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
3f35cde 
see: openshift/must-gather#400

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/must-gather-1 that referenced this pull request Apr 22, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
236f6aa 
see: openshift/must-gather#400

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot pushed a commit to kubevirt/must-gather that referenced this pull request Apr 24, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds (#212)
54e97fd 
see: openshift/must-gather#400

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaguclu ardaguclu ardaguclu left review comments

@soltysh soltysh soltysh approved these changes

@davemulford davemulford Awaiting requested review from davemulford

@sferich888 sferich888 Awaiting requested review from sferich888

Assignees

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@flavianmissi @openshift-ci-robot @ardaguclu @zhouying7780 @openshift-bot @soltysh