Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use must-gather since and since time env vars on inspect cmds #212

Merged
merged 1 commit into from
Apr 24, 2024
Merged

use must-gather since and since time env vars on inspect cmds #212

merged 1 commit into from
Apr 24, 2024

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Apr 11, 2024 •
edited
Loading

see: openshift/must-gather#400

Release note:

use must-gather since and since time env vars on inspect cmds

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 11, 2024
@tiraboschi
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot requested a review from nunnatsa April 11, 2024 16:06
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2024
nunnatsa
nunnatsa reviewed Apr 15, 2024
View reviewed changes
collection-scripts/gather_apiservices Outdated
@@ -3,6 +3,7 @@
DIR_NAME=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
source "${DIR_NAME}/common.sh"
check_command
get_log_collection_args
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to use it in this script?

@tiraboschi
Copy link
Member Author

/retest

@nunnatsa
Copy link
Collaborator

Now, that openshift/release#50856 was merged, let's retry

/pj-rehearse

@nunnatsa
Copy link
Collaborator

/test kubevirt-must-gather-e2e-gcp
/test kubevirt-must-gather-e2e-azure

@kubevirt-bot
Copy link

@nunnatsa: No presubmit jobs available for kubevirt/must-gather@main

In response to this:

/test kubevirt-must-gather-e2e-gcp
/test kubevirt-must-gather-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2024
@kubevirt-bot kubevirt-bot added size/L and removed lgtm Indicates that a PR is ready to be merged. size/M labels Apr 22, 2024
@tiraboschi
use must-gather since and since time env vars on inspect cmds
236f6aa 
see: openshift/must-gather#400

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi
Copy link
Member Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
nunnatsa
nunnatsa approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nunnatsa,tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 54e97fd into kubevirt:main Apr 24, 2024
6 checks passed
@tiraboschi tiraboschi deleted the since branch April 24, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiraboschi @nunnatsa @kubevirt-bot