-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding audit and host service log collection with oc #84
Conversation
/hold |
You don't need that PR unless you are running PR openshift/release#3560 ensures the images built for the release (which are used by the |
/test e2e-aws |
@sferich888 you can now test locally if you like. |
Oh, you can actually see it here. It's not working: https://gcsweb-ci.svc.ci.openshift.org/gcs/origin-ci-test/pr-logs/pull/openshift_must-gather/84/pull-ci-openshift-must-gather-master-e2e-aws/21/artifacts/e2e-aws/must-gather/ |
We need to update the README on how to do that! tl;dr builds the image and import it into the system so that you can use the alternate image. |
f513edf
to
af753b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@davemulford: changing LGTM is restricted to assignees, and only openshift/must-gather repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pair with: openshift/origin#22682 |
You need separate folders for kube and openshfit. Right now you're stomping on each other. |
@deads2k, good catch the latest push should have a fix for that. |
/hold cancel |
looks like it gathers the correct thing to me /assign @RickJWagner |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davemulford, RickJWagner, sferich888, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is dependant on #82 so that our image has the tools it needs to collect node logs (audit and services).