Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding audit and host service log collection with oc #84

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

sferich888
Copy link
Contributor

This PR is dependant on #82 so that our image has the tools it needs to collect node logs (audit and services).

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2019
@sferich888
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
collection-scripts/gather Outdated Show resolved Hide resolved
collection-scripts/gather Outdated Show resolved Hide resolved
collection-scripts/gather Outdated Show resolved Hide resolved
@sanchezl
Copy link
Contributor

This PR is dependant on #82 so that our image has the tools it needs to collect node logs (audit and services).

You don't need that PR unless you are running make images on the must-gather repository yourself and using those images.

PR openshift/release#3560 ensures the images built for the release (which are used by the oc adm must-gather command) have the cli tools.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2019
@sferich888
Copy link
Contributor Author

/test e2e-aws

@deads2k
Copy link
Contributor

deads2k commented Apr 26, 2019

This PR is dependant on #82 so that our image has the tools it needs to collect node logs (audit and services).

You don't need that PR unless you are running make images on the must-gather repository yourself and using those images.

@sferich888 you can now test locally if you like.

@deads2k
Copy link
Contributor

deads2k commented Apr 26, 2019

collection-scripts/gather Outdated Show resolved Hide resolved
collection-scripts/gather Outdated Show resolved Hide resolved
@sferich888
Copy link
Contributor Author

This PR is dependant on #82 so that our image has the tools it needs to collect node logs (audit and services).

You don't need that PR unless you are running make images on the must-gather repository yourself and using those images.

@sferich888 you can now test locally if you like.

We need to update the README on how to do that! tl;dr builds the image and import it into the system so that you can use the alternate image.

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@davemulford
Copy link

/lgtm

@openshift-ci-robot
Copy link

@davemulford: changing LGTM is restricted to assignees, and only openshift/must-gather repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sferich888
Copy link
Contributor Author

Pair with: openshift/origin#22682

@deads2k
Copy link
Contributor

deads2k commented Apr 26, 2019

You need separate folders for kube and openshfit. Right now you're stomping on each other.

@sferich888
Copy link
Contributor Author

@deads2k, good catch the latest push should have a fix for that.

@deads2k
Copy link
Contributor

deads2k commented Apr 26, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019
@deads2k
Copy link
Contributor

deads2k commented Apr 26, 2019

looks like it gathers the correct thing to me

/assign @RickJWagner
to own lgtm

@RickJWagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davemulford, RickJWagner, sferich888, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f5a9121 into openshift:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants