Bug 1775454: virtwhat multiple platform #42
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
pgier
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@pgier: This pull request references Bugzilla bug 1775454, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@pgier: This pull request references Bugzilla bug 1775454, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgier, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pgier: All pull requests linked via external trackers have merged. Bugzilla bug 1775454 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -18,10 +18,10 @@ rm -f "${v}" || true | |||
| touch "${v}" | |||
| if [ -x /usr/sbin/virt-what ] | |||
| then | |||
| platforms="$( virt-what )" | |||
| platforms=$(echo $( virt-what ) | tr '\n' ' ') | |||
There was a problem hiding this comment.
Why is this necessary? Testing locally, only removing the quotes around the ${platforms} is necessary.
There was a problem hiding this comment.
Also, how was this manifesting? I wasn't seeing this in the metrics -
count by (type) (max_over_time(cluster:virt_platform_nodes:sum[7d]))
was not showing an imbalance between xen and xen-hvm as I would expect if one of the tags was missing?
There was a problem hiding this comment.
You're right, this part is probably not necessary, I wasn't sure if the bash for loop would correctly handle newlines.
In the related bug, the textfile collector is failing because of the invalid format of the generated file. So it wasn't collecting the virt_platform metric at all for those nodes.
|
/cherry-pick release-4.3 |
|
@pgier: new pull request created: #45 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix cases where virtwhat returns multiple detected platforms.
Also provide a default path to TMPDIR in case the environment var isn't set.