Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1804012: On bare metal, detect system info #57

Merged
merged 1 commit into from Feb 18, 2020

Conversation

smarterclayton
Copy link

@smarterclayton smarterclayton commented Feb 7, 2020

Gather bios, baseboard, and system product/vendor/version info to assist debugging failures in specific hardware configurations. Is only gathered on bare metal since virtual environments will not return meaningful info.

In practice I expect the cardinality of this to be <10 series for the vast majority of clusters. I could imagine a few hodgepodge clusters, but the odds of a single large cluster having unique hardware for every node (on meaningful cluster sizes) is very small. And a cluster with hundreds of unique hardware configurations would almost certainly be a very strong pathological signal.

/hold

while i test on baremetal

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2020
Copy link

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Should we escape/drop double quotes from the dmidecode output just to be safe?

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2020
@smarterclayton
Copy link
Author

Yes, we probably should. Will add that after I test more.

/test images

@smarterclayton
Copy link
Author

Example from metal:

virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X10SLE",bios_vendor="American Megatrends Inc.",bios_version="2.00",endpoint="https",instance="worker-1.ci-ln-jiy6w42-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-5t9fm",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5038ML-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X10SLE",bios_vendor="American Megatrends Inc.",bios_version="3.2",endpoint="https",instance="worker-2.ci-ln-jiy6w42-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-tr9sm",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5038ML-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X11SSE-F",bios_vendor="American Megatrends Inc.",bios_version="1.0a",endpoint="https",instance="master-0.ci-ln-jiy6w42-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-glnpc",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5039MS-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X11SSE-F",bios_vendor="American Megatrends Inc.",bios_version="1.0b",endpoint="https",instance="master-2.ci-ln-jiy6w42-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-f9nw9",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5039MS-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X11SSE-F",bios_vendor="American Megatrends Inc.",bios_version="1.0b",endpoint="https",instance="worker-0.ci-ln-jiy6w42-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-nhtqq",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5039MS-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X11SSE-F",bios_vendor="American Megatrends Inc.",bios_version="2.1a",endpoint="https",instance="master-1.ci-ln-jiy6w42-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-65pkh",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5039MS-H12TRF",system_version="0123456789",type="none"} | 1

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
Gather bios, baseboard, and system product/vendor/version info to
assist debugging failures in specific hardware configurations. Is
only gathered on bare metal since virtual environments will not
return meaningful info.
Copy link

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pgier, simonpasquier, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pgier,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Author

virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X10SLE",bios_vendor="American Megatrends Inc.",bios_version="2.00",endpoint="https",instance="master-0.ci-ln-g94b4jk-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-lwl8m",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5038ML-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X10SLE",bios_vendor="American Megatrends Inc.",bios_version="2.00",endpoint="https",instance="master-2.ci-ln-g94b4jk-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-8zjnq",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5038ML-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X10SLE",bios_vendor="American Megatrends Inc.",bios_version="2.00",endpoint="https",instance="worker-1.ci-ln-g94b4jk-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-q6vbn",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5038ML-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X10SLE",bios_vendor="American Megatrends Inc.",bios_version="2.00",endpoint="https",instance="worker-2.ci-ln-g94b4jk-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-7lc9f",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5038ML-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X11SSE-F",bios_vendor="American Megatrends Inc.",bios_version="2.1a",endpoint="https",instance="master-1.ci-ln-g94b4jk-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-tpdch",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5039MS-H12TRF",system_version="0123456789",type="none"} | 1
virt_platform{baseboard_manufacturer="Supermicro",baseboard_product_name="X11SSE-F",bios_vendor="American Megatrends Inc.",bios_version="2.2a",endpoint="https",instance="worker-0.ci-ln-g94b4jk-86010.origin-ci-int-aws.dev.rhcloud.com",job="node-exporter",namespace="openshift-monitoring",pod="node-exporter-mlhw9",service="node-exporter",system_manufacturer="Supermicro",system_product_name="SYS-5039MS-H12TRF",system_version="0123456789",type="none"} | 1

@smarterclayton
Copy link
Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton smarterclayton changed the title text_collectors: On bare metal, detect system info Bug 1804012: On bare metal, detect system info Feb 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 18, 2020
@openshift-ci-robot
Copy link

@smarterclayton: This pull request references Bugzilla bug 1804012, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1804012: On bare metal, detect system info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a7d3a64 into openshift:master Feb 18, 2020
@openshift-ci-robot
Copy link

@smarterclayton: All pull requests linked via external trackers have merged. Bugzilla bug 1804012 has been moved to the MODIFIED state.

In response to this:

Bug 1804012: On bare metal, detect system info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link

/cherry-pick release-4.4

@openshift-cherrypick-robot

@paulfantom: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.4 and openshift-cherrypick-robot:cherry-pick-57-to-release-4.4"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants