New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1804012: On bare metal, detect system info #57
Bug 1804012: On bare metal, detect system info #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Should we escape/drop double quotes from the dmidecode
output just to be safe?
Yes, we probably should. Will add that after I test more. /test images |
Example from metal:
|
ad5c8f8
to
eb71e7e
Compare
Gather bios, baseboard, and system product/vendor/version info to assist debugging failures in specific hardware configurations. Is only gathered on bare metal since virtual environments will not return meaningful info.
eb71e7e
to
1177d45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgier, simonpasquier, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@smarterclayton: This pull request references Bugzilla bug 1804012, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@smarterclayton: All pull requests linked via external trackers have merged. Bugzilla bug 1804012 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@paulfantom: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.4 and openshift-cherrypick-robot:cherry-pick-57-to-release-4.4"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Gather bios, baseboard, and system product/vendor/version info to assist debugging failures in specific hardware configurations. Is only gathered on bare metal since virtual environments will not return meaningful info.
In practice I expect the cardinality of this to be <10 series for the vast majority of clusters. I could imagine a few hodgepodge clusters, but the odds of a single large cluster having unique hardware for every node (on meaningful cluster sizes) is very small. And a cluster with hundreds of unique hardware configurations would almost certainly be a very strong pathological signal.
/hold
while i test on baremetal