New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1803058: text_collectors: Don't detect AWS twice when virt-what is upgraded #60
Conversation
virt-what now detects AWS, we can safely ignore it if it is already present in the file.
hmm this looks similar to https://github.com/openshift/node_exporter/pull/58/files cc @paulfantom |
/retitle Bug 1803058: text_collectors: Don't detect AWS twice when virt-what is upgraded |
@smarterclayton: This pull request references Bugzilla bug 1803058, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.4 |
@paulfantom: new pull request created: #63 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
virt-what now detects AWS, we can safely ignore it if it is already
present in the file.