Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-1931: Update description in CSV #1008

Merged
merged 1 commit into from May 16, 2023
Merged

OADP-1931: Update description in CSV #1008

merged 1 commit into from May 16, 2023

Conversation

rayfordj
Copy link
Contributor

OADP-1931 Improve Cluster Service Version YAML's .metadata.annotations.description

@rayfordj
OADP-1931: Update description in CSV
e8e84d9 
[OADP-1931](https://issues.redhat.com/browse/OADP-1931) Improve Cluster Service Version YAML's .metadata.annotations.description
@rayfordj rayfordj self-assigned this May 16, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 16, 2023 •
edited by openshift-ci bot

@rayfordj: This pull request references OADP-1931 which is a valid jira issue.

In response to this:

OADP-1931 Improve Cluster Service Version YAML's .metadata.annotations.description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from eemcmullan and sseago May 16, 2023 15:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
shubham-pampattiwar
shubham-pampattiwar approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kaovilai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, rayfordj, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,rayfordj,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin weshayutin merged commit 5130524 into openshift:master May 16, 2023
9 of 12 checks passed
@rayfordj rayfordj deleted the OADP-1931-master branch May 16, 2023 17:59
@rayfordj
Copy link
Contributor Author

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link
Contributor

@rayfordj: new pull request created: #1010

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 16, 2023
Merged
rayfordj added a commit to rayfordj/oadp-operator that referenced this pull request May 22, 2023
@rayfordj
OADP-1931: Update description in CSV (openshift#1008)
e0461ad 
[OADP-1931](https://issues.redhat.com/browse/OADP-1931) Improve Cluster Service Version YAML's Description fields

Incorporate feedback from [comment](https://issues.redhat.com/browse/OADP-1931?focusedId=22320719&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-22320719)
rayfordj added a commit to rayfordj/oadp-operator that referenced this pull request May 22, 2023
@rayfordj
OADP-1931: Update description in CSV (openshift#1008)
25d0449 
[OADP-1931](https://issues.redhat.com/browse/OADP-1931) Improve Cluster Service Version YAML's Description fields

Incorporate feedback from [comment](https://issues.redhat.com/browse/OADP-1931?focusedId=22320719&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-22320719)
weshayutin pushed a commit that referenced this pull request May 22, 2023
@rayfordj
OADP-1931: Update description in CSV (#1008) (#1027)
d4a0972 
* OADP-1931: Update description in CSV (#1008)

[OADP-1931](https://issues.redhat.com/browse/OADP-1931) Improve Cluster Service Version YAML's Description fields

Incorporate feedback from [comment](https://issues.redhat.com/browse/OADP-1931?focusedId=22320719&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-22320719)

* Revert 'oneliner' description
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/oadp-operator that referenced this pull request May 22, 2023
@rayfordj
OADP-1931: Update description in CSV (openshift#1008)
313b121 
[OADP-1931](https://issues.redhat.com/browse/OADP-1931) Improve Cluster Service Version YAML's Description fields

Incorporate feedback from [comment](https://issues.redhat.com/browse/OADP-1931?focusedId=22320719&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-22320719)
openshift-merge-robot pushed a commit that referenced this pull request May 22, 2023
@openshift-cherrypick-robot @rayfordj
[oadp-1.2] OADP-1931: Update description in CSV (#1008) (#1029)
8ebd635 
* OADP-1931: Update description in CSV (#1008)

[OADP-1931](https://issues.redhat.com/browse/OADP-1931) Improve Cluster Service Version YAML's Description fields

Incorporate feedback from [comment](https://issues.redhat.com/browse/OADP-1931?focusedId=22320719&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-22320719)

* Revert 'oneliner' description

---------

Co-authored-by: Rayford Johnson <rayfordj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshayutin weshayutin weshayutin approved these changes

@sseago sseago sseago approved these changes

@kaovilai kaovilai kaovilai approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

Assignees

@weshayutin weshayutin

@sseago sseago

@rayfordj rayfordj

@kaovilai kaovilai

@shubham-pampattiwar shubham-pampattiwar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rayfordj @openshift-ci-robot @kaovilai @openshift-cherrypick-robot @weshayutin @sseago @shubham-pampattiwar